Skip to content

Conversation

@murtaza98
Copy link
Contributor

@murtaza98 murtaza98 commented Jun 29, 2022

Proposed changes (including videos or screenshots)

Issue(s)

One of the settings removed here #25993 was still getting used for getting the asterisk server URL causing this issue

Steps to test or reproduce

Further comments

@murtaza98 murtaza98 requested review from a team as code owners June 29, 2022 06:17
@murtaza98 murtaza98 requested a review from cauefcr June 29, 2022 06:17
@murtaza98 murtaza98 added this to the 5.0.0 milestone Jun 29, 2022
@murtaza98 murtaza98 changed the title Regression: Invalid Voip host issue causing issues while connecting to asterisk Regression: Invalid Voip host issue preventing agents connecting to asterisk Jun 29, 2022
@murtaza98 murtaza98 added the stat: ready to merge PR tested and approved waiting for merge label Jun 29, 2022
@murtaza98
Copy link
Contributor Author

murtaza98 commented Jun 29, 2022

Wierd seems like the auto-merge job is failing 🤷‍♂️ cc @ggazzo

@KevLehman
Copy link
Member

May be just acting up, happens sometimes in the day lol

@ggazzo
Copy link
Member

ggazzo commented Jun 29, 2022

Wierd seems like the auto-merge job is failing 🤷‍♂️ cc @ggazzo

its not, just relax there are other pr in the queue

ad guarantee that all requested reviewers actually reviewed the pull request is a good practice as well

@kodiakhq kodiakhq bot merged commit d3e5980 into develop Jun 29, 2022
@kodiakhq kodiakhq bot deleted the voip-reg/invalid-host-url-issue branch June 29, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants