[FIX] Users can access public discussions inside private channels they are not members of #25981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inside a `private channel`
matheusbsilva137
suggested changes
Jul 12, 2022
matheusbsilva137
changed the title
user to access public discussions inside private channels…ccess-discussion-private-room
matheusbsilva137
suggested changes
Jul 15, 2022
matheusbsilva137
approved these changes
Jul 15, 2022
9 tasks
debdutdeb
changed the title
LucianoPierdona
added
stat: QA tested
stat: ready to merge
Codecov Report
@@ Coverage Diff @@
## develop #25981 +/- ##
===========================================
+ Coverage 38.54% 38.68% +0.14%
===========================================
Files 758 759 +1
Lines 18827 18832 +5
Branches 1453 1453
===========================================
+ Hits 7256 7285 +29
+ Misses 11355 11330 -25
- Partials 216 217 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
debdutdeb
requested changes
Aug 17, 2022
debdutdeb
approved these changes
Aug 17, 2022
Member
|
Approving since I don't want my review to block the merge. This PR works (according to the qa-tested label) and is a critical fix. IMO no need to delay delivery just for this, can be addressed separately. |
kodiakhq
bot
deleted the
fix/outside-user-access-discussion-private-room
branch
csuadev
pushed a commit
that referenced
this pull request
Aug 26, 2022
…y are not members of (#25981)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #26266