Skip to content

Conversation

@hugocostadev
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@hugocostadev hugocostadev marked this pull request as ready for review June 22, 2022 10:52
@hugocostadev hugocostadev requested a review from a team as a code owner June 22, 2022 10:52
tassoevan
tassoevan previously approved these changes Jun 22, 2022
@tassoevan tassoevan dismissed their stale review June 22, 2022 20:35

Some checks are failing.

tassoevan
tassoevan previously approved these changes Jun 22, 2022
@hugocostadev hugocostadev added the stat: ready to merge PR tested and approved waiting for merge label Jun 23, 2022
@hugocostadev hugocostadev requested a review from tassoevan June 23, 2022 22:42
@github-actions github-actions bot removed the stat: ready to merge PR tested and approved waiting for merge label Jun 23, 2022
@github-actions github-actions bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jun 24, 2022
@hugocostadev hugocostadev added this to the 5.0.0 milestone Jun 27, 2022
tassoevan
tassoevan previously approved these changes Jun 27, 2022
@tassoevan tassoevan dismissed their stale review June 27, 2022 13:27

I want to review the security implications of changing the endpoint authorization

@hugocostadev hugocostadev requested a review from a team as a code owner June 27, 2022 16:49
@kodiakhq kodiakhq bot merged commit 0f40989 into develop Jun 29, 2022
@kodiakhq kodiakhq bot deleted the feature/CE-Watermark branch June 29, 2022 12:29
gabriellsh added a commit that referenced this pull request Jun 29, 2022
…turbo

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [NEW] Community Edition Watermark (#25844)
  [BREAK] remove unused endpoints and restify others (#25889)
  Chore: add underscore to ddp-streamer
  [IMPROVE] VoIP admin page cleanup: remove unused settings (#25993)
  Regression: Fix micro services (#26054)
  Regression: Fix threads list (#26052)
  [NEW] VoIP Input/Output Device Selection (#25966)
  Chore: Account/Profile to TS (#25929)
gabriellsh added a commit that referenced this pull request Jun 29, 2022
…/clientPackage

* 'develop' of github.com:RocketChat/Rocket.Chat: (80 commits)
  [NEW] Community Edition Watermark (#25844)
  [BREAK] remove unused endpoints and restify others (#25889)
  Chore: add underscore to ddp-streamer
  [IMPROVE] VoIP admin page cleanup: remove unused settings (#25993)
  Regression: Fix micro services (#26054)
  Regression: Fix threads list (#26052)
  [NEW] VoIP Input/Output Device Selection (#25966)
  Chore: Account/Profile to TS (#25929)
  Chore: Add missing Swedish livechat translations (#26048)
  [IMPROVE] Expand the feature set of the new message rendering (#25970)
  Chore: Bump fuselage and update icon (#26036)
  [NEW][APPS] Allowing apps to register authenticated routes (#25937)
  [NEW] Enable outbound calling for EE (#25843) (#25960)
  Chore: Introduce new index to query active livechat conversations for cloud scaling (#26047)
  [FIX] Importer fails to download files from URLs with query string params (#25934)
  [IMPROVE] Moved call hold/unhold to EE (#26007)
  [NEW] Engagement Metrics - Phase 2 (#25505)
  Chore: Convert usePreventDefault, useQueryOptions, useShortcutOpenMenu (#26035)
  [FIX] Importer files are unnecessarily transferred over the network. (#25919)
  Chore: test turbo params (#26038)
  ...
@murtaza98 murtaza98 mentioned this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants