[FIX] Slackbridge Connect Error #25793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucianoPierdona
changed the title
ggazzo
reviewed
Jun 8, 2022
ggazzo
reviewed
Jun 9, 2022
matheusbsilva137
previously approved these changes
Jun 15, 2022
Contributor
matheusbsilva137
left a comment
matheusbsilva137
left a comment
There was a problem hiding this comment.
The requested chanegs have been applied. LGTM
matheusbsilva137
approved these changes
Jul 26, 2022
Codecov Report
@@ Coverage Diff @@
## develop #25793 +/- ##
===========================================
+ Coverage 38.66% 38.68% +0.01%
===========================================
Files 759 759
Lines 18809 18809
Branches 1453 1453
===========================================
+ Hits 7273 7276 +3
+ Misses 11320 11315 -5
- Partials 216 218 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
added
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR fixes an issue that was happening when an invalid token was passed on SlackBridge, basically the app crashes because the error was not being handled
Issue(s)
Steps to test or reproduce
Further comments