[IMPROVE] Stabilization on federated rooms #25571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 1 alert when merging 92705a5 into 585801c - view on LGTM.com fixed alerts:
|
alansikora
added a commit
that referenced
this pull request
May 23, 2022
* adding settings file back * added js-yaml types * [IMPROVE] Stabilization on federated rooms (#25571) * chore: (wip) fixing proxy events handlers * chore: fix lint * fix: remove race condition + remove inline method * improve: general improvements for the mvp Co-authored-by: Marcos Defendi <marcos.defendi@rocket.chat> Co-authored-by: Aaron Ogle <aaron@geekgonecrazy.com>
ggazzo
pushed a commit
that referenced
this pull request
May 24, 2022
* adding settings file back * added js-yaml types * [IMPROVE] Stabilization on federated rooms (#25571) * chore: (wip) fixing proxy events handlers * chore: fix lint * fix: remove race condition + remove inline method * improve: general improvements for the mvp Co-authored-by: Marcos Defendi <marcos.defendi@rocket.chat> Co-authored-by: Aaron Ogle <aaron@geekgonecrazy.com>
ggazzo
pushed a commit
that referenced
this pull request
May 30, 2022
* adding settings file back * added js-yaml types * [IMPROVE] Stabilization on federated rooms (#25571) * chore: (wip) fixing proxy events handlers * chore: fix lint * fix: remove race condition + remove inline method * improve: general improvements for the mvp Co-authored-by: Marcos Defendi <marcos.defendi@rocket.chat> Co-authored-by: Aaron Ogle <aaron@geekgonecrazy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR aims to improve the federated rooms behavior.
It adds the ability to open and send/receive messages within
channels,private groupsanddirect messagesIssue(s)
Steps to test or reproduce
Further comments