Skip to content

[IMPROVE] Fix multiple bugs with Matrix bridge #25318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alansikora merged 6 commits into from
May 10, 2022
Merged

[IMPROVE] Fix multiple bugs with Matrix bridge #25318

alansikora merged 6 commits into from
May 10, 2022

Conversation

@MarcosSpessatto
Copy link
Contributor

@MarcosSpessatto MarcosSpessatto commented Apr 26, 2022 •
edited
Loading

Proposed changes (including videos or screenshots)

Issue(s)

  • Room was not visible on Rocket.Chat when I invited an user from the Matrix interface.
  • Invite slash command on RC side needed to be executed twice to take effect.
  • Messages were not being sent with a single room created on RC, the messages were being exchanged only from the second room on or if the Matrix user sents a message.
  • Config changes were requiring restart to take effect.

Steps to test or reproduce

Further comments

@MarcosSpessatto MarcosSpessatto marked this pull request as ready for review May 5, 2022 14:24
@MarcosSpessatto MarcosSpessatto self-assigned this May 5, 2022
@alansikora alansikora merged commit 035307c into develop May 10, 2022
@alansikora alansikora deleted the improvements/federation-v2-1 branch May 10, 2022 12:58
souzaramon pushed a commit that referenced this pull request May 11, 2022
[IMPROVE] Fix multiple bugs with Matrix bridge (#25318)
e90eebb 
* fix: use the existing user if it is local

* chore: fix lint

* fix: avoid to assign different types

* refactor: turn bridge into class and settings reactive
gabriellsh added a commit that referenced this pull request May 12, 2022
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into fix/…
109fa3b 
…lists

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Chore: Move admin sidebarItems registration to the main file (#25442)
  [FIX] Sanitize customUserStatus and fix infinite loop (#25449)
  [IMPROVE] Fix multiple bugs with Matrix bridge (#25318)
  Chore: Convert `UserStatusMenu` to TS (#25265)
  Chore: Chore add validation option to rest endpoints (#25443)
  Chore: Add channel endpoints (rest-typings) (#25279)
  Update Codeowners
  Chore: Dedicated package for UI contexts (#25432)
@d-gubert d-gubert mentioned this pull request May 31, 2022
Merged
@murtaza98 murtaza98 mentioned this pull request Jul 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geekgonecrazy geekgonecrazy Awaiting requested review from geekgonecrazy

2 more reviewers

@alansikora alansikora alansikora approved these changes

@carlosrodrigues94 carlosrodrigues94 carlosrodrigues94 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MarcosSpessatto MarcosSpessatto

Labels

squad: federation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MarcosSpessatto @alansikora @carlosrodrigues94