Skip to content

[FIX] NPS never finishing sending results #25067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sampaiodiego merged 1 commit into from
Apr 6, 2022
Merged

[FIX] NPS never finishing sending results #25067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/services/nps/sendNpsResults.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { SystemLogger } from '../../lib/logger/system';

type NPSResultPayload = {
total: number;
votes: INpsVote[];
votes: Pick<INpsVote, 'identifier' | 'roles' | 'score' | 'comment'>[];
};

export const sendNpsResults = Meteor.bindEnvironment(function sendNpsResults(npsId: string, data: NPSResultPayload) {
Expand Down
14 changes: 10 additions & 4 deletions server/services/nps/service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@ export class NPSService extends ServiceClassInternal implements INPSService {
},
{
projection: {
_id: 0,
identifier: 1,
roles: 1,
score: 1,
Expand All @@ -121,17 +120,24 @@ export class NPSService extends ServiceClassInternal implements INPSService {
}),
);

const votes = sending.filter(Boolean) as INpsVote[];
const votes = sending.filter(Boolean) as Pick<INpsVote, '_id' | 'identifier' | 'roles' | 'score' | 'comment'>[];
if (votes.length > 0) {
const voteIds = votes.map(({ _id }) => _id);

const votesWithoutIds = votes.map(({ identifier, roles, score, comment }) => ({
identifier,
roles,
score,
comment,
}));

const payload = {
total,
votes,
votes: votesWithoutIds,
};
sendNpsResults(nps._id, payload);

this.NpsVote.updateVotesToSent(voteIds);
await this.NpsVote.updateVotesToSent(voteIds);
}

const totalSent = await this.NpsVote.findByNpsIdAndStatus(nps._id, INpsVoteStatus.SENT).count();
Expand Down