Skip to content

[FIX] Use correct room property for call ended at #24932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KevLehman merged 1 commit into from
Apr 7, 2022
Merged

[FIX] Use correct room property for call ended at #24932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions client/views/omnichannel/directory/calls/contextualBar/VoipInfo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ type VoipInfoPropsType = {
export const VoipInfo = ({ room, onClickClose /* , onClickReport, onClickCall */ }: VoipInfoPropsType): ReactElement => {
const t = useTranslation();

const { servedBy, queue, v, fname, name, callDuration, callTotalHoldTime, callEndedAt, callWaitingTime, tags, lastMessage } = room;
const { servedBy, queue, v, fname, name, callDuration, callTotalHoldTime, closedAt, callWaitingTime, tags, lastMessage } = room;
const duration = callDuration && moment.utc(callDuration).format('HH:mm:ss');
const waiting = callWaitingTime && moment.utc(callWaitingTime).format('HH:mm:ss');
const hold = callTotalHoldTime && moment.utc(callTotalHoldTime).format('HH:mm:ss');
const endedAt = callEndedAt && moment(callEndedAt).format('LLL');
const endedAt = closedAt && moment(closedAt).format('LLL');
const phoneNumber = Array.isArray(v?.phone) ? v?.phone[0]?.phoneNumber : v?.phone;
const shouldShowWrapup = useMemo(() => lastMessage?.t === 'voip-call-wrapup' && lastMessage?.msg, [lastMessage]);
const shouldShowTags = useMemo(() => tags && tags.length > 0, [tags]);
Expand Down
2 changes: 0 additions & 2 deletions definition/IRoom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,6 @@ export interface IVoipRoom extends IOmnichannelGenericRoom {
callDuration?: number;
// The amount of time call was in queue in milliseconds
callWaitingTime?: number;
// The time when call was ended
callEndedAt?: Date;
// The total of hold time for call (calculated at closing time) in seconds
callTotalHoldTime?: number;
// The pbx queue the call belongs to
Expand Down