Release 3.7.0 #19048
Merged
Release 3.7.0 #19048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master into develop & Set version to 3.7.0-develop
* Update Meteor to 1.11 * Update Node version * Fix livechat view creation
Manual push by LingoHub User: Diego Sampaio. Project: Rocket.Chat Made with ❤️ by https://lingohub.com Co-authored-by: Diego Sampaio <chinello@gmail.com>
Replace [Nom du site] by [Site_Name]...
Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
* Remember users' 2FA right after registration * Change register server to false by default
* LingoHub Update 🚀 Manual push by LingoHub User: Diego Sampaio. Project: Rocket.Chat Made with ❤️ by https://lingohub.com * LingoHub Update 🚀 Manual push by LingoHub User: Diego Sampaio. Project: Rocket.Chat Made with ❤️ by https://lingohub.com Co-authored-by: Diego Sampaio <chinello@gmail.com>
…turns 404 (#18874) * chore(packages): add fixed version of ufs * test(e2e): test usernames with 'ufs' * test(ufs-router): remove expect for header * test: turn test callback synchronous * test: fix async to use done * chore(packages/meteor-jalik-ufs): add ufs package * Revert "test: fix async to use done" This reverts commit 6276e0b. * Revert "test: turn test callback synchronous" This reverts commit 2af11bb. * Revert "test(ufs-router): remove expect for header" This reverts commit 2c4eeb0.
* fix(ufs-proxy): correct routing pattern * chore(ufs-proxy): add deprecation console warning
Co-authored-by: Douglas Gubert <douglas.gubert@gmail.com>
Co-authored-by: Diego Sampaio <chinello@gmail.com>
* fixed message sending, you should not filter the domains, specially filter by only the local origin/source * Fixing callback registration * Increased the rate limiting
…m Apps (#19002) * Allow specify the encoding of the response data * Update Apps-Engine version Co-authored-by: Douglas Gubert <douglas.gubert@gmail.com> Co-authored-by: Douglas Gubert <d-gubert@users.noreply.github.com>
* [FIX] [Apps] Fix app user doesn't has permission to upload files * Fix errorClass [Error]: Forbidden [forbidden] In `app/file-upload/lib/FileUploadBase.js`, we configured `UploadFS.config.defaultStorePermissions`, which validates `insert(userId, doc)` etc. But the parameter userId cann't be always obtained by this validation method correctly (sometimes it's undefined). Meteor use the Meteor.userId() as its fallback option. So we can wrap the original call with `Meteor.runAsUser` to solve issue. * Add a new validator into canAccessRoom canAccessRoom (`app/authorization/server/functions/canAccessRoom.js`) is an essential validator for Rocket.Chat to check whether some user has permissions to access some room. In this PR, we added a new validator that allows app users to access any room on a Rocket.Chat server even if it is not a member of the room. * An attempt to fix Meteor code must always run within a Fiber Error Original Error: "Error: Meteor code must always run within a Fiber. Try wrapping callbacks that you pass to non-Meteor libraries with Meteor.bindEnvironment." * Add support for uploading files by a livecaht visitor * Support upload files with livechat visitors * Reduce an unnecessary DB query - Users.findOneById * Move the "bypass" out of canAccessRoom Adding a bypass inside canAccessRoom can potentially allow apps to do stuff we're not prepared (yet) * Update Apps-Engine version * Some refactoring * Fix a rateada Co-authored-by: Douglas Gubert <douglas.gubert@gmail.com>
…he App Settings (#19005) Co-authored-by: Douglas Gubert <d-gubert@users.noreply.github.com>
|
|
|
This pull request introduces 9 alerts and fixes 2 when merging 9c8c914 into a342846 - view on LGTM.com new alerts:
fixed alerts:
|
ggazzo
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2020-09-28 · 10 🎉 · 3 🚀 · 39 🐛 · 26 🔍 · 22 👩💻👨💻Engine versions
12.18.46.14.83.4, 3.6, 4.01.18.0🎉 New features
"Room avatar changed" system messages (#18839)
Apps: Add a Livechat API - setCustomFields (#18912)
Apps: Add a new upload API (#18955)
Apps: Add support for new livechat guest's and room's events (#18946)
Apps: Add support to the "encoding" option in http requests from Apps (#19002)
Apps-Engine v1.18.0 (#19047)
Option to require settings on wizard UI via ENV variables (#18974)
[NEW] Option to require settings on wizard UI via ENV variables
Retention policy precision defined by a cron job expression (#18975)
Send E2E encrypted messages’ content on push notifications (#18882)
Sends the content of end to end encrypted messages on Push Notifications allowing new versions of mobile apps to decrypt them and displays the content correctly.
UploadFS respects $TMPDIR environment variable (#17012 by @d-sko)
🚀 Improvements
Add "Allow_Save_Media_to_Gallery" setting (#18875)
Move jump to message outside menu (#18928)
Stop re-sending push notifications rejected by the gateway (#18608)
🐛 Bug fixes
"Download my data" popup showing HTML code. (#18947)
"Save to WebDav" not working (#18883)
ENTERPRISE: Omnichannel service status switching to unavailable (#18835)
API call users.setStatus does not trigger status update of clients (#18961 by @FelipeParreira)
Notify logged users via WebSockets message when a user changes status via REST API.
Block user action (#18950)
Can't change password (#18836)
Create Custom OAuth services from environment variables (#17377 by @mrtndwrd)
Custom fields required if minLength set and no text typed. (#18838)
Deactivate users that are the last owner of a room using REST API (#18864 by @FelipeParreira)
Allow for user deactivation through REST API (even if user is the last owner of a room)
Deactivated users show as offline (#18767)
Dutch: add translations for missing variables (#18814 by @Karting06)
e.sendToBottomIfNecessaryDebounced is not a function (#18834)
Errors in LDAP avatar sync preventing login (#18948)
Federation issues (#18978)
File upload (Avatars, Emoji, Sounds) (#18841)
French: Add missing online var (#18813 by @Karting06)
IE11 support livechat widget (#18850)
If there is
ufssomewhere in url the request to api always returns 404 (#18874 by @FelipeParreira)Ignore User action from user card (#18866)
invite-all-from and invite-all-to commands don't work with multibyte room names (#18919 by @FelipeParreira)
Jitsi call start updating subscriptions (#18837)
LDAP avatar upload (#18994)
Non-upload requests being passed to UFS proxy middleware (#18931 by @FelipeParreira)
Avoid non-upload request to be caught by UFS proxy middleware.
Omnichannel Current Chats open status filter not working (#18795)
Open room after guest registration (#18755)
PDF not rendering (#18956)
Purged threads still show as unread (#18944 by @FelipeParreira)
Remove threads from subscription (and update counter) when messages are purged (or threads are disabled).
Reaction buttons not behaving properly (#18832)
Read receipts showing blank names and not marking messages as read (#18918 by @wreiske)
Scrollbar mention ticks always rendering as white (#18979)
Show custom fields of invalid type (#18794)
Showing alerts during setup wizard (#18862)
Spurious expert role in startup data (#18667)
Stop adding push messages to queue if push is disabled (#18830)
User administration throwing a blank page if user has no role (#18851)
User can't invite or join other Omnichannel rooms (#18852)
User Info: Email and name/username display, alignment on big screens, make admin action (#18976)
Users not being able to activate/deactivate E2E in DMs (#18943)
[FIX] Users not being able to activate/deactivate E2E in DMs
Version update check cron job (#18916 by @wreiske)
🔍 Minor changes
Bump Livechat widget (#18977)
Bump lodash.merge from 4.6.1 to 4.6.2 (#18800 by @dependabot[bot])
Bump marked from 0.6.3 to 0.7.0 (#18801 by @dependabot[bot])
Check i18n file for missing variables (#18762)
Do not use deprecated express API (#18686)
Fix french translations (#18746 by @lsignac)
Fix saveRoomSettings method complexity (#18840)
Fix: Missing WebDav upload errors logs (#18849)
LingoHub based on develop (#18973)
LingoHub based on develop (#18828)
LingoHub based on develop (#18761)
Merge master into develop & Set version to 3.7.0-develop (#18752 by @thirsch)
New: Use database change streams when available (#18892)
Obey to settings properties (#19020)
Refactor: Admin permissions page (#18932)
Refactor: Message Audit page & Audit logs (#18808)
Refactor: Omnichannel Analytics (#18766)
Refactor: Omnichannel Realtime Monitoring (#18666)
Regression: Elements select & multiSelect not rendered correctly in the App Settings (#19005)
Regression: File upload via apps not working in some scenarios (#18995)
Regression: Fix login screen reactivity of external login providers (#19033)
Regression: Handle MongoDB authentication issues (#18993)
Replace copying assets on post-install with symlinks (#18707)
Set some queries to prefer the secondary database (#18887)
Update Meteor to 1.11 (#18754)
Update Meteor to 1.11.1 (#18959)
👩💻👨💻 Contributors 😍
👩💻👨💻 Core Team 🤓