Skip to content

[FIX] API call users.setStatus does not trigger status update of clients #18905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
FelipeParreira wants to merge 20 commits into from
Closed

[FIX] API call users.setStatus does not trigger status update of clients #18905

FelipeParreira wants to merge 20 commits into from

Conversation

@FelipeParreira
Copy link

@FelipeParreira FelipeParreira commented Sep 14, 2020

Proposed changes

This closes issue #18587.

Issue(s)

#18587

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Notify logged users via WebSockets message when a user changes status via REST API

Further comments

renatobecker and others added 10 commits September 11, 2020 10:12
@FelipeParreira
Copy link
Author

FelipeParreira commented Sep 14, 2020

I am not exactly sure how to (programmatically) test this.

I thought about spying on the Notifications function and maybe sniffing at WS messages being sent over the network, but none of this seems a very correct approach. Suggestions are welcome!

Felipe Parreira and others added 9 commits September 16, 2020 11:37
[FIX] invite-all-from and invite-all-to commands don't work with mult…
c4a6ffd 
…ibyte room names (#18919)
@mrtndwrd @sampaiodiego
[FIX] Create Custom OAuth services from environment variables (#17377)
ecf613e
@wreiske @sampaiodiego
[FIX] Read receipts showing blank names and not marking messages as r…
43bea4d 
…ead (#18918)
@wreiske @sampaiodiego
[FIX] Version update check cron job (#18916)
878f4c4
@pierre-lehnen-rc @sampaiodiego
[FIX] Ignore User action from user card (#18866)
457b967
@sampaiodiego
[FIX] Deactivate users that are the last owner of a room using REST A…
0147927 
…PI (#18864)

* test: add e2e tests for REST API user deactivation

* fix(app): read confirmRelinquish from HTTP request

* chore(app): remove unnecessary console.log
@gabriellsh @sampaiodiego
[FIX] Show custom fields of invalid type (#18794)
48e8e9d
@sampaiodiego
Bump version to 3.6.2
e613f2a
@sampaiodiego
Merge pull request #18942 from RocketChat/release-3.6.2
7301fc4 
Release 3.6.2
@sampaiodiego sampaiodiego changed the title [FIX] API call users.setStatus does not trigger status update of clients #18587 [FIX] API call users.setStatus does not trigger status update of clients Sep 18, 2020
@sampaiodiego sampaiodiego changed the base branch from master to develop September 18, 2020 20:26
@sampaiodiego sampaiodiego changed the base branch from develop to master September 18, 2020 20:26
@FelipeParreira FelipeParreira changed the base branch from master to develop September 18, 2020 20:31
@FelipeParreira FelipeParreira changed the base branch from develop to master September 18, 2020 20:31
@FelipeParreira FelipeParreira changed the base branch from master to develop September 18, 2020 20:36
@FelipeParreira
Copy link
Author

FelipeParreira commented Sep 18, 2020

Moved to #18961

@FelipeParreira FelipeParreira deleted the hotfix-user-status-update branch September 18, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sampaiodiego sampaiodiego Awaiting requested review from sampaiodiego

@pierre-lehnen-rc pierre-lehnen-rc Awaiting requested review from pierre-lehnen-rc

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

API call users.setStatus does not trigger status update of clients

8 participants

@FelipeParreira @renatobecker @ggazzo @sampaiodiego @mrtndwrd @wreiske @pierre-lehnen-rc @gabriellsh