[FIX] Sending notifications from senders without a name #18479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/Rocket.Chat into fix-notification-without-name
ggazzo
approved these changes
Aug 7, 2020
gabriellsh
added a commit
that referenced
this pull request
Aug 10, 2020
…omni * 'develop' of github.com:RocketChat/Rocket.Chat: [NEW] Add REST API endpoint to search Livechat visitors (#18514) LingoHub based on develop (#18516) Update README.md (#18503) [NEW] Channel avatar (#18443) [FIX] Sending notifications from senders without a name (#18479) [FIX] UserCard avatar cache (avatarETag) (#18466) [IMPROVE] Admin Info page requires permission (#18408) [FIX] Marking room as read with unread threads still (#18410) [FIX] Random generated password not matching the Password Policy (#18475) Typo in privacy agreement message (#18476) bugfix for uploading files from livechat (#18474) LingoHub based on develop (#18465) [NEW] Add the ability to set the character message limit on Livechat widget (#18261) [FIX] Migration 194 (#18457) [FIX] Omnichannel session monitor is not starting (#18412) [FIX] Invalid MIME type when uploading audio files (#18426) [FIX] Error when updating omnichannel department without agents parameter (#18428) [FIX] Omnichannel Take Inquiry endpoint checking wrong permission (#18446) [FIX] Multiple push notifications sent via native drivers (#18442) [FIX] Appending 'false' to Jitsi URL (#18430)
sampaiodiego
added a commit
that referenced
this pull request
Aug 13, 2020
* Save error and skip from queue
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add a fallback to use the username if a user doesn't have a name and the server config is set to user real names when sending push notifications.
If the server config is set to user real names and a notification from a user without a name is scheduled to be sent it will trigger a validation error because the notification will be missing a
title, that was intended to be the user's name, causing an infinite loop.Also when an error happens while trying to send the notification I'm now removing it from the queue and setting an error property for further investigation.
Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Changelog
Further comments