Fix the update check not working #17809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graywolf336
commented
Jun 2, 2020
| @@ -40,7 +36,11 @@ export default () => { | |||
| }); | |||
|
|
|||
| check(data, Match.ObjectIncluding({ | |||
| versions: [String], | |||
There was a problem hiding this comment.
This is one reason why the previous version won't work.
graywolf336
commented
Jun 2, 2020
|
|
||
| const params = { | ||
| uniqueId: uniqueID.value, | ||
| installedAt: uniqueID.createdAt, | ||
| installedAt: uniqueID.createdAt.toJSON(), |
There was a problem hiding this comment.
This is another reason why the previous version won't work. Sadly, meteor has an issue parameterizing date objects.
| @@ -62,7 +62,7 @@ export default () => { | |||
| msg: `*${ TAPi18n.__('Rocket_Chat_Alert', adminUser.language) }:*\n\n*${ TAPi18n.__(alert.title, adminUser.language) }*\n${ TAPi18n.__(alert.text, ...alert.textArguments || [], adminUser.language) }\n${ alert.infoUrl }`, | |||
| })), | |||
| banners: alerts.map((alert) => ({ | |||
| id: `alert-${ alert.id }`, | |||
| id: `alert-${ alert.id }`.replace(/\./g, '_'), | |||
There was a problem hiding this comment.
Needed because otherwise with a dot its inserting and nesting. So like in the version one it was nesting like:
versionUpdate-3: {
'3': {
'0': banner
}
}
rodrigok
approved these changes
Jun 2, 2020
|
@rodrigok @sampaiodiego any ideas on how to keep the banners portion of the users object from becoming super bloated? After a while it would get pretty large. With the authentication tokens in the past I believe the size became an issue. |
|
@geekgonecrazy we probably will need to reevaluate that later, or creating a limit of number of banners or doing a proper API for that (better IMO) |
ggazzo
added a commit
that referenced
this pull request
Jun 3, 2020
…/new-threads * 'develop' of github.com:RocketChat/Rocket.Chat: (38 commits) [IMPROVE][Federation] Add support for _tcp and protocol DNS entries (#17818) Fix the update check not working (#17809) Add Apps-Engine to Engine Versions on History (#17810) [FIX] Link preview containing HTML encoded chars (#16512) [FIX] Email link "go to message" being incorrectly escaped (#17803) [FIX] Error when re-installing an App (#17789) Update Apps-Engine version (#17804) Fix invalid develop payload to release service (#17799) Readme: Update Raspberry Pi 2 to Pi 4 (#17031) [NEW] Accept variable `#{userdn}` on LDAP group filter (#16273) [FIX] Spotify embed link opens in same tab (#13637) [FIX] Markdown links not accepting URLs with parentheses (#13605) [NEW][API] Endpoint `settings.addCustomOAuth` to create Custom OAuth services (#14912) [IMPROVE] Make the implementation of custom code easier by having placeholders for a custom folder (#15106) [NEW] Skip Export Operations that haven't been updated in over a day (#16135) [NEW] Highlight matching words in message search results (#16166) [FIX] Set `x-content-type-options: nosniff` header (#16232) [FIX] Disabling `Json Web Tokens protection to file uploads` disables the File Upload protection entirely (#16262) Fixes some italian word (#14008) Bump version to 3.4.0-develop ...
gabriellsh
added a commit
that referenced
this pull request
Jun 4, 2020
…rewrite_admin_sidebar * 'develop' of github.com:RocketChat/Rocket.Chat: [FIX] When the message is too long declining to send as an attachment does not restore the content into the composer (#16332) [IMPROVE][Federation] Add support for _tcp and protocol DNS entries (#17818) Fix the update check not working (#17809) Add Apps-Engine to Engine Versions on History (#17810) [FIX] Link preview containing HTML encoded chars (#16512) [FIX] Email link "go to message" being incorrectly escaped (#17803) [FIX] Error when re-installing an App (#17789) Update Apps-Engine version (#17804) Fix invalid develop payload to release service (#17799)
Merged
sampaiodiego
pushed a commit
that referenced
this pull request
Jun 10, 2020
Co-authored-by: Aaron Ogle <geekgonecrazy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix the update checker.
How to test or reproduce
Implement the update check endpoint and wait for it to be hit. Realize it isn't being hit.
Types of changes
Checklist
Further comments
No idea how long this has been broken now.
Also, the reason we changed the format of the id for the banner is because if you previously dismissed the
versionUpdatebanner then it wouldn't display again. This will obviously increase the size of the user object in the database, so how do we go about implementing a fix for this?