[FIX] Bot Agents not being able to get Omnichannel Inquiries #17404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampaiodiego
requested changes
Apr 24, 2020
Improve the return statement.
sampaiodiego
approved these changes
Apr 24, 2020
ggazzo
added a commit
that referenced
this pull request
Apr 27, 2020
…/new-threads * 'develop' of github.com:RocketChat/Rocket.Chat: [FIX] Bot Agents not being able to get Omnichannel Inquiries (#17404) [FIX] Allowing blocking a user on channels (#17406) Fix moving-to-a-single-codebase link in README (#17297) Regression: Fix mem usage with more than one argument (#17391)
sampaiodiego
pushed a commit
that referenced
this pull request
Apr 27, 2020
Merged
ggazzo
added a commit
that referenced
this pull request
Apr 28, 2020
…to adm/custom_status * 'admin-refactor' of github.com:RocketChat/Rocket.Chat: [IMPROVE] Redesign Administration > Invites (#17390) Bump version to 3.1.2 [FIX] LDAP error when trying to add room with spaces in the name (#17453) Regression: Add missing cacheKey to mem (#17430) [FIX] Empty Incoming webhook script field (#17422) [FIX] LDAP Sync error (#17417) [FIX] Bot Agents not being able to get Omnichannel Inquiries (#17404) [FIX] Allowing blocking a user on channels (#17406) Regression: Fix mem usage with more than one argument (#17391) [FIX] Web Client memory leak caused by the Emoji library (#17320) [FIX] Omnichannel room info panel opening whenever a message is sent (#17348) [FIX] New user added by admin doesn't receive random password email (#17249) [FIX] LDAP error when trying to add room with spaces in the name (#17453) Complement Guest role restrictions for Enterprise (#17393) Regression: Add missing cacheKey to mem (#17430) Remove `@typescript-eslint/explicit-function-return-type` rule (#17428) [FIX] Empty Incoming webhook script field (#17422) [FIX] LDAP Sync error (#17417) [FIX] Bot Agents not being able to get Omnichannel Inquiries (#17404)
ggazzo
added a commit
that referenced
this pull request
May 6, 2020
* 'develop' of github.com:RocketChat/Rocket.Chat: (30 commits) [IMPROVE] [Apps-Engine] App user as the default notifier (#17050) [NEW] [Apps-Engine] New Livechat event handlers (#17033) [FIX] Change email verification label (#17450) Priority system messages were always created (#17479) Bump version to 3.3.0-develop Bump version to 3.2.0 Bump version to 3.1.2 [FIX] LDAP error when trying to add room with spaces in the name (#17453) Regression: Add missing cacheKey to mem (#17430) [FIX] Empty Incoming webhook script field (#17422) [FIX] LDAP Sync error (#17417) [FIX] Bot Agents not being able to get Omnichannel Inquiries (#17404) [FIX] Allowing blocking a user on channels (#17406) Regression: Fix mem usage with more than one argument (#17391) [FIX] Web Client memory leak caused by the Emoji library (#17320) [FIX] Omnichannel room info panel opening whenever a message is sent (#17348) [FIX] New user added by admin doesn't receive random password email (#17249) Bump version to 3.2.0-rc.2 [FIX] LDAP error when trying to add room with spaces in the name (#17453) Complement Guest role restrictions for Enterprise (#17393) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLOSES #17405.
Since
3.1version we only allow online agents/users to get Omnichannel Inquiries.Unfortunately, external systems are now facing an issue because they have bot agents that get the Omnichannel Inquiries through the REST API endpoint ->
livechat/inquiries.take.As the current implementation doesn't check the
botrole, the external user just can't get the inquiry because thebotrole isn't being checked as we do in another similar process.