Skip to content

[FIX] FileUpload.getBuffer was not working through the Apps-Engine #16234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
renatobecker merged 1 commit into from
Jan 13, 2020
Merged

[FIX] FileUpload.getBuffer was not working through the Apps-Engine #16234

renatobecker merged 1 commit into from
Jan 13, 2020

Conversation

@renatobecker
Copy link
Contributor

@renatobecker renatobecker commented Jan 13, 2020 •
edited
Loading

There was a converter missing when calling the FileUpload.getBuffer from theApps-Engine.
Due to that the File Buffer returned was always the same, because of the _id of the file was missing in the payload provided by the Apps-Engine.

@renatobecker renatobecker added this to the 3.0.0 milestone Jan 13, 2020
@claassistantio
Copy link

claassistantio commented Jan 13, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@renatobecker renatobecker changed the title [FIX] FileUpload.getBuffer method was not working properly through the Apps-Engine [FIX] FileUpload.getBuffer was not working through the Apps-Engine Jan 13, 2020
@renatobecker renatobecker merged commit 8bba7f8 into develop Jan 13, 2020
@renatobecker renatobecker deleted the fix-get-file-buffer-from-apps-engine branch January 13, 2020 21:36
sampaiodiego pushed a commit that referenced this pull request Jan 14, 2020
@renatobecker @sampaiodiego
Merge pull request #16234 from RocketChat/fix-get-file-buffer-from-ap…
993044f 
…ps-engine

[FIX] FileUpload.getBuffer was not working through the Apps-Engine
@sampaiodiego sampaiodiego mentioned this pull request Feb 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d-gubert d-gubert d-gubert approved these changes

@rodrigok rodrigok Awaiting requested review from rodrigok

@sampaiodiego sampaiodiego Awaiting requested review from sampaiodiego

Assignees

No one assigned

Labels

type: bug

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@renatobecker @claassistantio @d-gubert