[NEW] Accept quoted slash command arguments

[Hudell]

This change will make the app engine recognize quoted strings as a single argument for slash commands, even when they have spaces on it.

It will also accept multiple lines of arguments
Closes #11469

[kapkoi]

Pada Sab, 11 Ogo 2018 1:28 AM Pierre H. Lehnen <notifications@github.com> menulis:

…

This change will make the app engine recognize quoted strings as a single argument for slash commands, even when they have spaces on it ------------------------------ You can view, comment on, or merge this pull request online at: #11744 Commit Summary - Changed the apps api to recognize quotes on slash command arguments File Changes - *M* packages/rocketchat-apps/server/bridges/commands.js <https://github.com/RocketChat/Rocket.Chat/pull/11744/files#diff-0> (28) Patch Links: - https://github.com/RocketChat/Rocket.Chat/pull/11744.patch - https://github.com/RocketChat/Rocket.Chat/pull/11744.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#11744>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AmmjgoIu_C_hLvXeFM2Tg0xFv6OQMsYQks5uPcLLgaJpZM4V4jTm> .

[kapkoi]

packages/rocketchat-apps/server/bridges/commands.js <https://github.com/RocketChat/Rocket.Chat/pull/11744/files#diff-0> Pada Sab, 11 Ogo 2018 1:31 AM Kap Koi <kapkoi360@gmail.com>menulis: packages/rocketchat-apps/server/bridges/commands.js <https://github.com/RocketChat/Rocket.Chat/pull/11744/files#diff-0>

…

Pada Sab, 11 Ogo 2018 1:28 AM Pierre H. Lehnen ***@***.***> menulis: > This change will make the app engine recognize quoted strings as a single > argument for slash commands, even when they have spaces on it > ------------------------------ > You can view, comment on, or merge this pull request online at: > > #11744 > Commit Summary > > - Changed the apps api to recognize quotes on slash command arguments > > File Changes > > - *M* packages/rocketchat-apps/server/bridges/commands.js > <https://github.com/RocketChat/Rocket.Chat/pull/11744/files#diff-0> > (28) > > Patch Links: > > - https://github.com/RocketChat/Rocket.Chat/pull/11744.patch > - https://github.com/RocketChat/Rocket.Chat/pull/11744.diff > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#11744>, or mute the > thread > <https://github.com/notifications/unsubscribe-auth/AmmjgoIu_C_hLvXeFM2Tg0xFv6OQMsYQks5uPcLLgaJpZM4V4jTm> > . >

[sampaiodiego]

does it accepts escaped quotes? like "my \"escaped\" argument"

[Hudell]

It does now.

[rodrigok]

@Hudell can you fix the lint errors?

[Hudell]

@rodrigok done.

[piotrkochan]

Could you also resolve #11469 ?

[Hudell]

I'll look into it.

[gabrielaolson]

I tested it and it is working as expected:
APP:
parameters_0.0.1.zip

Input String quoted and multiple lines:

Output: