-
Notifications
You must be signed in to change notification settings - Fork 13.1k
[IMPROVE] Start storing Livechat department within rooms #11733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
# Conflicts: # packages/rocketchat-livechat/client/views/app/tabbar/visitorHistory.js # packages/rocketchat-livechat/server/lib/Livechat.js # packages/rocketchat-livechat/server/methods/getInitialData.js # packages/rocketchat-livechat/server/methods/registerGuest.js
# Conflicts: # packages/rocketchat-livechat/.app/client/views/register.js
sampaiodiego
approved these changes
Aug 21, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation: needed
Needs addition/changes to documentation
squad: omnichannel
subj: livechat
type: improvement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11618
This PR brings several improvements related to the Livechat departments.
Now, when the visitor chooses a specific department on Livechat register form or using Livechat iFrame API, the department's
idwill be stored within theLivechat Room.This implementation also aims to provide departments data to new Livechat Admin. Dashboards, which are been implemented in our Livechat GSoC project.
Other issue detected during this implementation is fixed. The issue was related to Livechat visitor history, which is displayed on Rocket.Chat side and provides a list of visitor's oldest chats. If the agent attempted to access an old chat that wasn't served by the logged agent, the
Roomdata wasn't available in theirChatRoomclient collection. Because of this we will only display older chats that have been served by the current user/agent.