Skip to content

Conversation

@renatobecker-zz
Copy link

@renatobecker-zz renatobecker-zz commented Aug 9, 2018

Closes #11618

This PR brings several improvements related to the Livechat departments.
Now, when the visitor chooses a specific department on Livechat register form or using Livechat iFrame API, the department's id will be stored within the Livechat Room.

This implementation also aims to provide departments data to new Livechat Admin. Dashboards, which are been implemented in our Livechat GSoC project.

Other issue detected during this implementation is fixed. The issue was related to Livechat visitor history, which is displayed on Rocket.Chat side and provides a list of visitor's oldest chats. If the agent attempted to access an old chat that wasn't served by the logged agent, the Room data wasn't available in their ChatRoom client collection. Because of this we will only display older chats that have been served by the current user/agent.

# Conflicts:
#	packages/rocketchat-livechat/client/views/app/tabbar/visitorHistory.js
#	packages/rocketchat-livechat/server/lib/Livechat.js
#	packages/rocketchat-livechat/server/methods/getInitialData.js
#	packages/rocketchat-livechat/server/methods/registerGuest.js
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11733 August 16, 2018 20:14 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11733 August 16, 2018 20:29 Inactive
@RocketChat RocketChat deleted a comment Aug 16, 2018
@RocketChat RocketChat deleted a comment Aug 16, 2018
@RocketChat RocketChat deleted a comment Aug 16, 2018
@RocketChat RocketChat deleted a comment Aug 16, 2018
@RocketChat RocketChat deleted a comment Aug 16, 2018
@RocketChat RocketChat deleted a comment Aug 16, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11733 August 16, 2018 20:53 Inactive
# Conflicts:
#	packages/rocketchat-livechat/.app/client/views/register.js
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11733 August 17, 2018 14:57 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11733 August 17, 2018 14:59 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11733 August 17, 2018 17:20 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11733 August 17, 2018 17:22 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11733 August 19, 2018 19:57 Inactive
@sampaiodiego sampaiodiego merged commit d24f262 into develop Aug 21, 2018
@sampaiodiego sampaiodiego deleted the livechat-update-fields-register-guest branch August 21, 2018 00:54
@sampaiodiego sampaiodiego mentioned this pull request Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Livechat: Forward by Department not working.

5 participants