[FIX] Return room ID for groups where user joined #11703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampaiodiego
requested changes
Aug 13, 2018
Member
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
can you please submit only the proposed changes? which I think is only this c42274b
that looks good to me
timkinnane
force-pushed
the
hotfix/fix-getRoomIdByNameOrId
branch
from
c42274b to
d37fe92
Compare
Contributor
Author
|
@sampaiodiego Oops. I had branched my fix from master instead of develop. Re-submitted with patch applied to develop now. |
Contributor
Author
|
@sampaiodiego can we move forward with this? More comments coming in on #11552 as evidence how critical this is.
|
Member
|
sure thing. I'm just trying to make CI build this |
sampaiodiego
approved these changes
Aug 15, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #11552