[FIX] Push notifications stuck after db failure #11667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Yeeeeeees! :hugging: RocketChat/push@022aa53 glad this was the issue and you were able to fork and try it! |
geekgonecrazy
previously approved these changes
Aug 3, 2018
geekgonecrazy
approved these changes
Aug 7, 2018
Merged
Contributor
|
@geekgonecrazy @sampaiodiego so this PR should fix #8038 ? :) |
Member
Author
|
yes it does.. thanks @TheReal1604 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this Meteor-Community-Packages/raix-push#344 isn't merged I have forked that package and released a new version with that fix.
The fix prevents a failure on polling query from preventing to send push notifications.