[FIX] REST endpoints to update user not respecting some settings #11474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmShaegar13
suggested changes
Jul 17, 2018
| }); | ||
| } | ||
|
|
||
| if (userData.name && !RocketChat.settings.get('Accounts_AllowEmailChange')) { |
Contributor
There was a problem hiding this comment.
Looks like you made a little copy&paste error here. ;) Should be userData.email I guess.
tests/end-to-end/api/01-users.js
Outdated
| }); | ||
|
|
||
| it('should return an error when trying update user email and it is not allowed', (done) => { | ||
| updateSetting('Accounts_AllowEmailChange', false) |
Contributor
There was a problem hiding this comment.
I am curious why this test did not find the bug from above. Maybe you need beforeEach to reset settings?
Reordering tests fixed the problem.
Change wrong comparation in saveUser function
AmShaegar13
previously approved these changes
Jul 17, 2018
Contributor
AmShaegar13
left a comment
AmShaegar13
left a comment
There was a problem hiding this comment.
Looks good to me now. 👍
Contributor
|
Any reason this PR is not in 0.68 release? |
sampaiodiego
changed the title
sampaiodiego
approved these changes
Aug 17, 2018
Member
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
I'm concerned if we're duplicating most of these tests in many places. we need to re-evaluate this in the future.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.