fix review

.meteor/.id

@@ -0,0 +1,7 @@
+# This file contains a token that is unique to your project.
+# Check it into your repository along with the rest of this directory.
+# It can be used for purposes such as:
+#   - ensuring you don't accidentally deploy one app on top of another
+#   - providing package authors with aggregated statistics
+
+u4k2dnt1ek.uewj3t4xsn4

packages/rocketchat-api/server/v1/chat.js

@@ -321,18 +321,19 @@ RocketChat.API.v1.addRoute('chat.reportMessage', { authRequired: true }, {
 RocketChat.API.v1.addRoute('chat.ignoreUser', { authRequired: true }, {
 	get() {
 		const { rid, userId } = this.queryParams;
-		let { ignore = false } = this.queryParams;
+		let { ignore = true } = this.queryParams;
 
-		ignore = typeof ignore === typeof '' ? /true|1/.test(ignore) : ignore;
+		ignore = typeof ignore === 'string' ? /true|1/.test(ignore) : ignore;
 
 		if (!rid || !rid.trim()) {
 			throw new Meteor.Error('error-room-id-param-not-provided', 'The required "rid" param is missing.');
 		}
+
 		if (!userId || !userId.trim()) {
 			throw new Meteor.Error('error-user-id-param-not-provided', 'The required "userId" param is missing.');
 		}
 
-		Meteor.runAsUser(this.userId, () => Meteor.call('ignoreUser', { rid, userId, ignore}));
+		Meteor.runAsUser(this.userId, () => Meteor.call('ignoreUser', { rid, userId, ignore }));
 
 		return RocketChat.API.v1.success();
 	}

packages/rocketchat-lib/server/lib/sendNotificationsOnMessage.js

@@ -222,7 +222,7 @@ RocketChat.callbacks.add('afterSaveMessage', function(message, room, userId) {
 			return;
 		}
 
-		if (subscription.ignored && subscription.ignored.find(message.u._id)) {
+		if (Array.isArray(subscription.ignored) && subscription.ignored.find(message.u._id)) {
 			return;
 		}
 

packages/rocketchat-ui-flextab/client/tabs/membersList.js

@@ -81,7 +81,7 @@ Template.membersList.helpers({
 		}
 		// show online users first.
 		// sortBy is stable, so we can do this
-		users = _.sortBy(users, u => u.status ===	 'offline');
+		users = _.sortBy(users, u => u.status === 'offline');
 
 		let hasMore = undefined;
 		const usersLimit = Template.instance().usersLimit.get();

packages/rocketchat-ui/client/lib/RoomHistoryManager.js

@@ -132,7 +132,9 @@ export const RoomHistoryManager = new class {
 		if (ts) {
 			return Meteor.call('loadNextMessages', rid, ts, limit, function(err, result) {
 				for (const msg of Array.from((result != null ? result.messages : undefined) || [])) {
-					if (msg.t !== 'command') { upsertMessage({msg, subscription}); }
+					if (msg.t !== 'command') {
+						upsertMessage({msg, subscription});
+					}
 				}
 
 				Meteor.defer(() => RoomManager.updateMentionsMarksOfRoom(typeName));
@@ -189,7 +191,9 @@ export const RoomHistoryManager = new class {
 
 			return Meteor.call('loadSurroundingMessages', message, limit, function(err, result) {
 				for (const msg of Array.from((result != null ? result.messages : undefined) || [])) {
-					if (msg.t !== 'command') { upsertMessage({msg, subscription}); }
+					if (msg.t !== 'command') {
+						upsertMessage({msg, subscription});
+					}
 				}
 
 				Meteor.defer(function() {

packages/rocketchat-ui/client/lib/RoomManager.js

@@ -224,9 +224,7 @@ const loadMissedMessages = function(rid) {
 	}
 	const subscription = ChatSubscription.findOne({rid});
 	return Meteor.call('loadMissedMessages', rid, lastMessage.ts, (err, result) =>
-		Array.from(result).map(item =>
-			RocketChat.promises.run('onClientMessageReceived', item).then(msg => upsertMessage({msg, subscription})
-			))
+		Array.from(result).map(item => RocketChat.promises.run('onClientMessageReceived', item).then(msg => upsertMessage({msg, subscription})))
 	);
 };