[Bug] legacy message template diplays nothing

[xmedeko]

Description:

When i switch Use legacy message template in 5.1.0, then nothing is displayed in a chat room.

Steps to reproduce:

1. Switch My Prefrences > Global > Use legacy message template

Expected behavior:

See chat messages as in 5.0.5

Actual behavior:

Nothing is displayed.

Server Setup Information:

• Version of Rocket.Chat Server: 5.1.0

[shevchukma]

I confirm. We have this problem too.

[ankar84]

Totally confirm that issue on our test 5.1.0 environment.
New template

Legacy template

[Gummikavalier]

I confirm this too. Clearing caches did not help either.

[fne007]

We are having exactly the same problem using the latest 5.1.0 release. With legacy mode we got empty channels and without Legacy mode we got more or less broken Webhooks. It Would be really great if someone could address this problem.

[treebes]

Same here.

If legacy off, i can see the messages, but the code view of webhooks gets broken.

[hugocostadev]

Hi guys, the fix is in progress...

Besides the webhook issue that @treebes mentioned, are you found any other restrictions to start using the new Message Parser?

It is important to know because our idea is for to everyone use the new Message parser feature. Thanks

[treebes]

@hugocostadev for us was the onlyone we detected so far, this issue began on the 5.0 realease.

I belive is the same issue from here.
#26388

[Gummikavalier]

For what these are worth, here is my current list of issues with the new template I've been trying to track. Not sure if all not listed fixed are still active issues. Some may have been fixed.

The list of problems with the new template:
 * Emoji size issue between web client and mobile client, betraying user being on mobile
 * Resolving reaction names is even worse than in the old template
 * Some links may break depending on characters used (that did not break with the old template)
 * :+1: emoji issue (is translated as a phone number regardless that tel.nos are disabled globally
 * Sometimes after switching the channel the new messages you write, or new reactions you set, just don't appear on the channel until you refresh the window
 * [NEW] Messages don't show at all in legacy message template
 
Ok:
 * [Obsolete] Cozy / Compact did not work, using too much space by default. Likely to be obsolete, use top bar display settings or web client zoom out instead.
 * [Works as intended] Old code blocks break if they don't have a line ending after the triple-` (The original way of operation may have been a bug though, as you are supposed to put the type of code block after the first triple quote when these are used correctly.)
 * [Fixed] Bridged messages nicks are broken (this is the real no-go for the new template)
 * [Fixed]  : -character issue that always transforms any :'s into emojis after pressing enter
 * [Likely fixed] Link preview content size rendering issues. Could not reproduce anymore.

Actual blockers for moving to use the new template would be any webhook or visibility issues.

[xmedeko]

@hugocostadev Just check this issue tracker, there are many problem with the new message parser, see #26736 and #26736 (comment) for a humble list of some of them.

Note: seems to me you have a poor management of issues - some of them are left without reaction, some are duplicate, some has been fixed but not closed, etc.

[chotaire]

I question the project management as a whole.

They release an entirely broken message parser in a new stable major version (is there actually QA?) and break everyone's installations. They refuse to revert to a previously working state (downgrade is also not supported btw) but take weeks for "we fix it until it works". Then they mention people can just switch to the old message parser, which leaves countless installations in a state of using deprecated components: How many admins will likely keep an eye on development and switch back to the new message parser when it's finally working, the legacy message parser works so well they'll forget about it. It gets even worse when normal users experiencing this issue stroll GitHub and switch back to the legacy message parser in their personal settings, because the admin can't even revert that later. Instead the guys at Rocket.Chat could simply have released an update that quickly reverts to the legacy message parser by default until it is fixed (with people still being able to toggle to the new parser if they feel adventurous). Finally they break the legacy message parser too, leaving everyone who updated to 5.x with huge problems. Is any developer actually really testing the message parser, which means using their own software? We're not talking corner cases, this is an issue reproduced as easy as that: Let's post a link, oh look it's obviously broken. Immediate steps should have been taken the same day of release, like an instant revert if the fix takes longer (that's understandable).

Really guys, a stable version is not a public beta-test for a basic feature that must always work. There are currently 2800+ open issues, it looks many of them are never read or cleaned up. And I am getting the idea everyone is just coding random features, someone merges and releases them without actually testing them, and voila there is your stable release, let's hope it works.

The Rocket.Chat project was severely damaged with the new message parser, more specifically, how it was handled. It's absolutely ok to release something buggy, we're humans, but it's not ok not to revert! How all of this was handled was anything but enterprise. I hope Rocket.Chat is learning a lesson from all this, because people are losing trust.