Replacing magic numbers in the code by settings

[vibl]

There are a few "magic numbers" in the code, such as in

Rocket.Chat/app/lib/server/functions/saveUser.js

Line 231 in a1c41a1

if (typeof bio !== 'string' || bio.length > 260) {

In this example, is there a reason why 260 has not been replaced by something like settings.get('Accounts_MaxBioLength')? (With the corresponding setting added to app/lib/server/startup/settings.ts).

[has12zen]

Hello, can I work on this Issue?

[has12zen]

@vibl Can You Check the changes and give your feedback?

[aakash-gitdev]

Hi, I have made some changes in the code according to the request. Can someone please do my PR review? I am just a beginner in making PR's.

[gabriellsh]

Hello! So, as I commented here, generally adding settings for this kind of stuff isn't a good idea. It adds little value and unnecessary complexity for maintaining it afterwards.

A better option for it would be to add a const with a descriptive name so we know what the number means.

[vibl]

Being able to change these settings is quite valuable for some use cases. I'm using Rocket.chat for a community where people don't necessarily know each other and we definitely need the Bio field to be longer.