[3.6.1] Non admin cannot add custom avatar to group

[acceptMyPR]

Description:

As in #18785 non admin still cannot add custom avatar to group
Then you saving avatar there is an error on server:

Exception in setTimeout callback: TypeError: Cannot read property 'etag' of undefined
    at app/lib/server/functions/setRoomAvatar.js:34:46
    at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js:1234:12)
    at packages/meteor.js:550:25
    at runWithEnvironment (packages/meteor.js:1286:24)

Steps to reproduce:

1. Click channel and click Room information
2. Click edit and click upload and choose I want change avatar
3. Click save but not change avatar

Expected behavior:

Changing avatar

Actual behavior:

Server Setup Information:

• Version of Rocket.Chat Server: 3.6.1
• Operating System: Linux
• Deployment Method: kubernetes
• Number of Running Instances:
• DB Replicaset Oplog:
• NodeJS Version:
• MongoDB Version:

Client Setup Information

• Desktop App or Browser Version: 2.17.11
• Operating System: MacOS

Additional context

Relevant logs:

[klepptor]

Same here, 3.6.1:

I20200914-06:27:47.337(0) Exception in setTimeout callback: TypeError: Cannot read property 'etag' of undefined at app/lib/server/functions/setRoomAvatar.js:34:46 at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js:1234:12) at packages/meteor.js:550:25 at runWithEnvironment (packages/meteor.js:1286:24)

[lelvisl]

#18841

[ankar84]

@sampaiodiego @geekgonecrazy Channel Avatars shouldn't consider as released feature until that issue is fixed.
Indeed it's not released if only admins can change channels avatars.
But it is on release notes.

[Weuxel]

Also in 3.7.0

[atemp]

In 3.7.1 it seems once the admin changed a channel avatar, the owner can change it again. But not before.

[ankar84]

I did try to change room avatar as Admin from Admin UI - Rooms with no luck.
Here is example of what that avatar looked like

Only after I was invited to that chat I successfully set avatar.

[danel1]

Same problem here with 3.6.2 and the newest desktop client for macOS.

I20201019-08:52:58.781(0) Exception in setTimeout callback: TypeError: Cannot read property 'etag' of undefined     at app/lib/server/functions/setRoomAvatar.js:34:46     at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js:1234:12)     at packages/meteor.js:550:25     at runWithEnvironment (packages/meteor.js:1286:24)

[cprice-kgi]

i've uploaded a PR today that should resolve this issue:
#19340

[ankar84]

Fixed on open.rocket.chat which on version 3.8-rc0

[sampaiodiego]

right.. fix on latest 3.8 release.