fix: forwarding a message twice does not render the attachment

[OtavioStasiak]

Proposed changes

When forwarding messages with file attachments files from forwarded messages remain invisible to users. Files located in nested attachment structures are not processed or displayed by the Reply component.

Issue(s)

https://rocketchat.atlassian.net/browse/SUP-986

How to test or reproduce

• Open the app;
• Go to room with a attachment message;
• Forward it twice;

Screenshots

Before	After

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• Improvement (non-breaking change which improves a current function)
• New feature (non-breaking change which adds functionality)
• Documentation update (if none of the other choices apply)

Checklist

• I have read the CONTRIBUTING doc
• I have signed the CLA
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works (if applicable)
• I have added necessary documentation (if applicable)
• Any dependent changes have been merged and published in downstream modules

Further comments

Summary by CodeRabbit

• New Features

  • Nested attachments now render as reply-style attachments within messages.

• Bug Fixes

  • Quote detection improved to ignore collapsed items and attachments that contain nested attachments.

• Tests

  • Added Storybook stories showcasing nested reply/file attachments, a collapsible attachment with text, and a large-font variant.

[coderabbitai]

Walkthrough

Renders nested attachments using the Reply component when an attachment has its own attachments; tightens quote detection to early-exclude collapsed attachments and attachments with children; adds Storybook stories covering nested replies and collapsible-attachment cases.

Changes

Cohort / File(s)	Summary
Attachment rendering & quote logic app/containers/message/Components/Attachments/Attachments.tsx, app/containers/message/Components/Attachments/Quote.tsx	removeQuote and isQuoteAttachment now consider file.collapsed and file.attachments (early-return guards). Attachments.tsx adds a branch to render Reply when an attachment contains nested attachments, preserving existing Image/Audio/Video/AttachedActions/CollapsibleQuote paths.
Storybook test cases app/containers/message/Message.stories.tsx	Adds MessageWithNestedReplyAndFile, CollapsibleAttachmentWithText, CollapsibleAttachmentWithTextLargeFont stories and a collapsibleAttachmentWithText fixture to exercise nested-reply and collapsible-attachment rendering.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Client as Client
  participant MessageComp as Message
  participant AttachmentsComp as Attachments
  participant ReplyComp as Reply
  participant MediaRenderers as Image/Audio/Video/AttachedActions/CollapsibleQuote
  Client->>MessageComp: render message with attachments
  MessageComp->>AttachmentsComp: pass attachments array
  AttachmentsComp->>AttachmentsComp: evaluate removeQuote / isQuoteAttachment (checks collapsed, attachments)
  alt attachment contains attachments
    AttachmentsComp->>ReplyComp: render nested Reply for attachment
    ReplyComp->>AttachmentsComp: (may render nested attachments)
  else attachment is image/audio/video/action/collapsible
    AttachmentsComp->>MediaRenderers: render appropriate renderer
  end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• regression: Collapsible quote not rendering after #6121 #6677: Modifies removeQuote predicate in Attachments.tsx to change handling of collapsed attachments.
• fix: File rendering as URL #6725: Related changes to Reply handling and nested-attachment rendering overlap with this PR.
• fix: quote image not loading #6698: Adjusts isQuoteAttachment logic in Quote.tsx, similar guard-condition changes.

Suggested reviewers

• diegolmello

Poem

🐰
I hop through code with nimble paws,
Nested replies obey new laws.
Collapsed I skip, no quote to keep,
Attachments wake from nested sleep.
Stories bloom — a joyful leap! 📎✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Linked Issues check	❓ Inconclusive	The linked issue SUP-986 has no detailed description available to validate whether all coding requirements are met.	Access the full description of SUP-986 to verify all nested attachment visibility requirements are addressed by the code changes.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely summarizes the main bugfix: forwarding a message twice does not properly render attachments, which matches the core change in the PR.
Out of Scope Changes check	✅ Passed	All changes directly address the nested attachment rendering issue: extending removeQuote logic, adding Reply component rendering for nested attachments, and adding test stories for nested cases.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix.forward-message-twice-not-render-image

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Fix all issues with AI agents

In `@app/containers/message/Components/Attachments/Attachments.tsx`:
- Around line 76-85: The nested-attachment branch fails to pass the
already-computed msg into the Reply component, so update the JSX that renders
<Reply key={index} attachment={file} ... /> to include the msg prop (e.g.,
msg={msg}) so Reply receives the computed message for translated text/display;
locate the rendering in Attachments.tsx where Reply is returned for
file.attachments?.length and add the msg prop alongside attachment, timeFormat,
getCustomEmoji and showAttachment.

In `@app/containers/message/Components/Attachments/Quote.tsx`:
- Around line 11-18: isQuoteAttachment currently doesn't exclude attachments
that contain nested attachments, so nested items can be rendered both as a Quote
and again in Attachments; add an early guard in isQuoteAttachment to return
false when the incoming file has a non-empty attachments array (e.g.
file.attachments && file.attachments.length > 0) so its behavior mirrors
removeQuote and prevents duplicate rendering in Quote and Attachments.

[Rohit3523]

LGTM