Skip to content

chore: migrate axios with fetch #6837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Rohit3523 wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

chore: migrate axios with fetch #6837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2077ca1
remove axios
Rohit3523 Dec 4, 2025
71b75d4
replace axios with fetch
Rohit3523 Dec 4, 2025
bae8068
mock fetch
Rohit3523 Dec 6, 2025
08f3953
Improve verify image
Rohit3523 Dec 6, 2025
95c5038
Added story and update snapshot
Rohit3523 Dec 6, 2025
b172879
lint fix
Rohit3523 Dec 6, 2025
5521616
chore: format code and fix lint issues [skip ci]
Rohit3523 Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 67 additions & 0 deletions app/containers/message/Message.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -915,6 +915,73 @@ export const WithFile = () => (
</>
);

export const WithUrl = () => (
<>
<Message
msg='Single URL'
urls={[
{
title: 'Better code structure · Issue #1 · RocketChat/Rocket.Chat.ReactNative',
description:
'There are some options to improve the code structure: Read the Building Chatty to get ideas Add redux Rename file meteor.js to RocketChat to encapsulate the API to populate realm Separate views to ...',
url: 'https://github.com/RocketChat/Rocket.Chat.ReactNative/pull/1',
image:
'https://opengraph.githubassets.com/3279b1c919656914846f7e133d6b77526f1182ffd64e7f7d67a01258bb7c190f/RocketChat/Rocket.Chat.ReactNative/issues/1'
}
]}
/>
<Message
msg='Multiple URLs'
urls={[
{
title: 'Better code structure · Issue #1 · RocketChat/Rocket.Chat.ReactNative',
description:
'There are some options to improve the code structure: Read the Building Chatty to get ideas Add redux Rename file meteor.js to RocketChat to encapsulate the API to populate realm Separate views to ...',
url: 'https://github.com/RocketChat/Rocket.Chat.ReactNative/pull/1',
image:
'https://opengraph.githubassets.com/3279b1c919656914846f7e133d6b77526f1182ffd64e7f7d67a01258bb7c190f/RocketChat/Rocket.Chat.ReactNative/issues/1'
},
{
title: 'Better code structure · Issue #1 · RocketChat/Rocket.Chat.ReactNative',
description:
'There are some options to improve the code structure: Read the Building Chatty to get ideas Add redux Rename file meteor.js to RocketChat to encapsulate the API to populate realm Separate views to ...',
url: 'https://github.com/RocketChat/Rocket.Chat.ReactNative/pull/1',
image:
'https://opengraph.githubassets.com/3279b1c919656914846f7e133d6b77526f1182ffd64e7f7d67a01258bb7c190f/RocketChat/Rocket.Chat.ReactNative/issues/1'
}
]}
/>
<Message
msg='URL with no image'
urls={[
{
title: 'Better code structure · Issue #1 · RocketChat/Rocket.Chat.ReactNative',
description:
'There are some options to improve the code structure: Read the Building Chatty to get ideas Add redux Rename file meteor.js to RocketChat to encapsulate the API to populate realm Separate views to ...',
url: 'https://github.com/RocketChat/Rocket.Chat.ReactNative/pull/1'
}
]}
/>
<Message
msg='URL with only title'
urls={[
{
title: 'Better code structure · Issue #1 · RocketChat/Rocket.Chat.ReactNative'
}
]}
/>
<Message
msg='URL with only description'
urls={[
{
description:
'There are some options to improve the code structure: Read the Building Chatty to get ideas Add redux Rename file meteor.js to RocketChat to encapsulate the API to populate realm Separate views to ...'
}
]}
/>
</>
);

export const WithFileLargeFont = () => (
<>
<MessageLargeFont
Expand Down
12 changes: 9 additions & 3 deletions app/containers/message/Urls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { StyleSheet, Text, View, type ViewStyle } from 'react-native';
import Clipboard from '@react-native-clipboard/clipboard';
import { Image } from 'expo-image';
import { dequal } from 'dequal';
import axios from 'axios';

import { useAppSelector } from '../../lib/hooks/useAppSelector';
import Touchable from './Touchable';
Expand Down Expand Up @@ -139,8 +138,15 @@ const Url = ({ url }: { url: IUrl }) => {
const _imageUrl = getImageUrl();
if (!_imageUrl || !API_Embed) return;

const response = await axios.head(_imageUrl);
const contentType = response.headers['content-type'];
const response = await fetch(_imageUrl, {
method: 'HEAD'
});

if (!response.ok) {
return;
}

const contentType = response.headers.get('content-type');
if (contentType?.startsWith?.('image/')) {
setImageUrl(_imageUrl);
}
Expand Down
Loading