Skip to content

chore: Merge 4.66.1 into single-server#6773

Merged
diegolmello merged 2 commits intosingle-serverfrom
4.66.1
Nov 7, 2025
Merged

chore: Merge 4.66.1 into single-server#6773
diegolmello merged 2 commits intosingle-serverfrom
4.66.1

Conversation

@diegolmello
Copy link
Member

@diegolmello diegolmello commented Nov 7, 2025

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Summary by CodeRabbit

  • Chores

    • Updated application version to 4.66.1 across Android, iOS, and web platforms to align versioning across all distributions.
  • Bug Fixes

    • Improved image URL handling in messages with more reliable detection and verification mechanisms for better content display consistency.

diegolmello and others added 2 commits November 6, 2025 11:03
* Fix image preview crashing on large pdfs

* Update snapshots

* Update app/containers/message/Urls.tsx

Co-authored-by: Noach Magedman <nmagedman@gmail.com>

---------

Co-authored-by: Noach Magedman <nmagedman@gmail.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 7, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Version bump from 4.66.0 to 4.66.1 across Android, iOS, and npm configurations. URL image validation logic in Urls.tsx refactored with memoized function and HTTP HEAD request verification.

Changes

Cohort / File(s) Summary
Version Bump
android/app/build.gradle, package.json, ios/RocketChatRN.xcodeproj/project.pbxproj, ios/RocketChatRN/Info.plist, ios/ShareRocketChatRN/Info.plist
Version string updated from 4.66.0 to 4.66.1 across Android build configuration, iOS project/plist files, and npm package metadata.
URL Image Validation Refactor
app/containers/message/Urls.tsx
Introduced memoized getImageUrl function via useCallback to compute fully qualified image URLs. Changed imageUrl state type to `string

Sequence Diagram

sequenceDiagram
    participant Component as Urls Component
    participant useCallback as getImageUrl<br/>(memoized)
    participant Effect as useEffect
    participant API as HTTP API
    participant State as imageUrl State

    Effect->>useCallback: Call with url params
    useCallback->>useCallback: Compute image URL<br/>(url.image or url.url)
    useCallback-->>Effect: Return _imageUrl

    Effect->>Effect: Check _imageUrl exists

    rect rgb(200, 220, 250)
        Note over Effect,API: URL Validation Phase
        Effect->>API: HEAD request<br/>to _imageUrl
        API-->>Effect: Response with<br/>content-type
    end

    rect rgb(220, 250, 220)
        Note over Effect,State: Conditional Update
        Effect->>Effect: Verify content-type<br/>indicates image
        Effect->>State: Update imageUrl<br/>with _imageUrl
    end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~20 minutes

  • app/containers/message/Urls.tsx: Verify useCallback dependency array completeness, validate HTTP HEAD request error handling and content-type checking logic, confirm state initialization and type changes (string | null) are correct, and ensure URL detection change (startsWith vs includes) doesn't introduce edge cases.
  • Version files: Quick verification that version string 4.66.1 is consistently applied across all five configuration files.

Possibly related PRs

Poem

🐰 A version hops from four-six-six-oh to one,
Through Android, iOS, and configs—all files done!
In Urls.tsx, memos dance and callbacks sing,
With HEAD requests validating everything. ✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 4.66.1

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between ae56c04 and f106f3c.

⛔ Files ignored due to path filters (1)
  • app/containers/message/__snapshots__/Message.test.tsx.snap is excluded by !**/*.snap
📒 Files selected for processing (6)
  • android/app/build.gradle (1 hunks)
  • app/containers/message/Urls.tsx (2 hunks)
  • ios/RocketChatRN.xcodeproj/project.pbxproj (2 hunks)
  • ios/RocketChatRN/Info.plist (1 hunks)
  • ios/ShareRocketChatRN/Info.plist (1 hunks)
  • package.json (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@diegolmello diegolmello merged commit 2f81800 into single-server Nov 7, 2025
43 of 50 checks passed
@diegolmello diegolmello deleted the 4.66.1 branch November 7, 2025 11:41
@diegolmello diegolmello had a problem deploying to experimental_android_build November 7, 2025 11:44 — with GitHub Actions Failure
@diegolmello diegolmello had a problem deploying to experimental_ios_build November 7, 2025 11:44 — with GitHub Actions Failure
@diegolmello diegolmello had a problem deploying to official_android_build November 7, 2025 11:44 — with GitHub Actions Failure
@coderabbitai coderabbitai bot mentioned this pull request Nov 27, 2025
10 tasks
@coderabbitai coderabbitai bot mentioned this pull request Feb 4, 2026
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant