Skip to content

fix: android native theme sync#6029

Draft
Rohit3523 wants to merge 9 commits intoRocketChat:developfrom
Rohit3523:dark-theme-modal
Draft

fix: android native theme sync#6029
Rohit3523 wants to merge 9 commits intoRocketChat:developfrom
Rohit3523:dark-theme-modal

Conversation

@Rohit3523
Copy link
Contributor

@Rohit3523 Rohit3523 commented Nov 29, 2024

Proposed changes

This PR addresses an issue where Android native components display themes based on the operating system's settings, which may differ from the app's chosen theme. The implementation introduces a native module that synchronizes the app's theme with system settings, ensuring consistent visual rendering across all app components.
Additionally, this pull request modifies the modal text and background color to align with the active app theme.

Issue(s)

N/A

How to test or reproduce

  1. Set Android system theme to light mode
  2. Open app and set app theme to dark mode
  3. Try to delete any message
  4. Notice the delete alert shows in light theme

Screenshots

Scenario Android Theme App Theme Before After
Scenario 1 Dark Light Before Video After Video
Scenario 2 Light Dark Before Video After Video

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

@Rohit3523 Rohit3523 marked this pull request as draft January 8, 2025 17:15
@Rohit3523
Copy link
Contributor Author

This change is still pending for iOS because I couldn't work on the native code due to issues building the debug version caused by the Xcode version.

However, support for Xcode 16.2.0 was recently added, so I'll resume work soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant