Skip to content

feat: Room AI Actions#5999

Merged
yash-rajpal merged 10 commits intofeat/ai-app-actionsfrom
feat/room-app-actions
Nov 25, 2024
Merged

feat: Room AI Actions#5999
yash-rajpal merged 10 commits intofeat/ai-app-actionsfrom
feat/room-app-actions

Conversation

@yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Nov 18, 2024

Proposed changes

AI App actions on room actions list

Issue(s)

How to test or reproduce

Screenshots

image

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

RCAI-24

@yash-rajpal yash-rajpal marked this pull request as ready for review November 21, 2024 16:57
const hasOneRoleResult = hasOneRole ? hasOneRole.some(role => mergedRoles.includes(role)) : true;
const hasAllRolesResult = hasAllRoles ? hasAllRoles.every(role => mergedRoles.includes(role)) : true;

return hasOnePermissionResult && hasAllPermissionsResult && hasOneRoleResult && hasAllRolesResult;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base automatically changed from feat/persist-app-actions to feat/ai-app-actions November 25, 2024 05:18
@yash-rajpal yash-rajpal merged commit 7b497be into feat/ai-app-actions Nov 25, 2024
@yash-rajpal yash-rajpal deleted the feat/room-app-actions branch November 25, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants