feat: Fetch and persist app action buttons#5935
Merged
yash-rajpal merged 16 commits intofeat/ai-app-actionsfrom Nov 25, 2024
Merged
feat: Fetch and persist app action buttons#5935yash-rajpal merged 16 commits intofeat/ai-app-actionsfrom
yash-rajpal merged 16 commits intofeat/ai-app-actionsfrom
Conversation
diegolmello
requested changes
Nov 21, 2024
| const isMethodCall = endpoint?.startsWith('method.call/'); | ||
| try { | ||
| const result = await this.current.post(endpoint, params); | ||
| const result = await this.current.post(endpoint, params, undefined, undefined, undefined, apiVersion); |
Member
There was a problem hiding this comment.
Commenting just so we're all aware, but this is only reasonable because there's a work here that would make it possible to call sdk.post specifying api version in a more elegant way.
sdk.post('/v1/..., sdk.post('/apps/...
Hopefully this is only temporary 😬
diegolmello
reviewed
Nov 21, 2024
diegolmello
approved these changes
Nov 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fetching and storing all Rocket.Chat app actions in watermelon DB and redux state.
Also implemented real-time handling of this stored data based on streamed data from server related to apps changes.
Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments
RCAI-23