-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: migrate to bluesky-social/react-native-bottom-sheet #5769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
956cbf9
feat: migrate to bluesky-social/react-native-bottom-sheet
dnlsilva 5b9549d
feat: adds accessibility to action sheet items
dnlsilva 37916d4
test: fix tests
dnlsilva 6205378
fix lint
dnlsilva 78486ad
fix types
dnlsilva 64fc2af
Merge branch 'develop' into fix-action-sheet-acessibility
dnlsilva File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| diff --git a/node_modules/@discord/bottom-sheet/src/components/bottomSheetHandleContainer/BottomSheetHandleContainer.tsx b/node_modules/@discord/bottom-sheet/src/components/bottomSheetHandleContainer/BottomSheetHandleContainer.tsx | ||
| index 2219e0f..59f90ba 100644 | ||
| --- a/node_modules/@discord/bottom-sheet/src/components/bottomSheetHandleContainer/BottomSheetHandleContainer.tsx | ||
| +++ b/node_modules/@discord/bottom-sheet/src/components/bottomSheetHandleContainer/BottomSheetHandleContainer.tsx | ||
| @@ -92,10 +92,6 @@ function BottomSheetHandleContainerComponent({ | ||
| > | ||
| <Animated.View | ||
| key="BottomSheetHandleContainer" | ||
| - accessible={true} | ||
| - accessibilityRole="adjustable" | ||
| - accessibilityLabel="Bottom Sheet handle" | ||
| - accessibilityHint="Drag up or down to extend or minimize the Bottom Sheet" | ||
| onLayout={handleContainerLayout} | ||
| > | ||
| <HandleComponent | ||
| diff --git a/node_modules/@discord/bottom-sheet/src/utilities/animate.ts b/node_modules/@discord/bottom-sheet/src/utilities/animate.ts | ||
| index 0ce4c9a..9562675 100644 | ||
| --- a/node_modules/@discord/bottom-sheet/src/utilities/animate.ts | ||
| +++ b/node_modules/@discord/bottom-sheet/src/utilities/animate.ts | ||
| @@ -4,6 +4,7 @@ import { | ||
| withTiming, | ||
| withSpring, | ||
| AnimationCallback, | ||
| + ReduceMotion, | ||
| } from 'react-native-reanimated'; | ||
| import { ANIMATION_CONFIGS, ANIMATION_METHOD } from '../constants'; | ||
|
|
||
| @@ -26,6 +27,8 @@ export const animate = ({ | ||
| configs = ANIMATION_CONFIGS; | ||
| } | ||
|
|
||
| + configs.reduceMotion = ReduceMotion.Never; | ||
| + | ||
| // detect animation type | ||
| const type = | ||
| 'duration' in configs || 'easing' in configs |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.