Changing ProfileView Class Component to Hook Component#5646
Changing ProfileView Class Component to Hook Component#5646anirbanpaulcom wants to merge 7 commits intoRocketChat:developfrom
Conversation
|
@GleidsonDaniel , @diegolmello , Please take a look. |
| user.bio === bio && | ||
| user.nickname === nickname && | ||
| !newPassword && | ||
| user.name === state.name && |
There was a problem hiding this comment.
I don't know if you personally changed it or used some tool to make this change, but just this block here "kills" the migration, using a simple state for this entire flow will make the performance of this screen much worse.
The correct option would be useReduce or a form lib.
There was a problem hiding this comment.
@GleidsonDaniel #5544 This PR will solve the problem. This PR is for integrating react-hook-form. Let me know if any other files, like RegisterView need to be changed from class to function components.
|
Hey @diegolmello, #5544 this PR is for integrating |
|
Hey @diegolmello, #5544 this PR is for integrating |
|
Hey @diegolmello, #6166 and #5543 both can be solved by this, please take a look. |
|
Closing in favor of #6036 |
Proposed changes
Changing
ProfileViewfrom a class component to a hook component for usingreact-hook-form.Issue(s)
Solves This Issue : #5544
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments