Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Supported Versions #5185

Merged
merged 80 commits into from
Oct 19, 2023
Merged

feat: Supported Versions #5185

merged 80 commits into from
Oct 19, 2023

Conversation

diegolmello
Copy link
Member

@diegolmello diegolmello commented Aug 24, 2023 •
edited by jira bot
Loading

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

NBJ-250

dnlsilva
dnlsilva suggested changes Oct 6, 2023
View reviewed changes
diegolmello
diegolmello commented Oct 16, 2023
View reviewed changes
app/lib/methods/checkSupportedVersions-enforcement.test.ts Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated test file because all of these are temp only and it changes logic based on enforcementStartDate.
I'm going to remove it on next release.

@diegolmello
Merge branch 'develop' into feat.lts
96e58cc 
# Conflicts:
#	app/i18n/locales/pt-BR.json
@diegolmello diegolmello merged commit 18b77ab into develop Oct 19, 2023
@diegolmello diegolmello deleted the feat.lts branch October 19, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnlsilva dnlsilva dnlsilva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diegolmello @dnlsilva