Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate LoginView to hooks #5092

Merged
merged 7 commits into from
Oct 18, 2023

Conversation

reinaldonetof
Copy link
Contributor

@reinaldonetof reinaldonetof commented May 29, 2023

Proposed changes

migrate LoginView to hooks

Issue(s)

How to test or reproduce

  • Test the login and the errors, for example: wrong password, wrong email, user not found
  • login with Github, Gmail, or other services

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

NATIVE-12

@reinaldonetof reinaldonetof self-assigned this May 29, 2023
@dnlsilva
Copy link
Contributor

Add a better how to test.

@reinaldonetof reinaldonetof dismissed diegolmello’s stale review October 18, 2023 17:23

approved and qa tested

@reinaldonetof reinaldonetof merged commit 3f2e5ce into develop Oct 18, 2023
@reinaldonetof reinaldonetof deleted the chore.migrate-login-view-to-hooks branch October 18, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants