Skip to content

[IMPROVE] Message body readability on dark themes #2981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegolmello merged 10 commits into from
Jul 5, 2021
Merged

[IMPROVE] Message body readability on dark themes #2981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
022f06c
[CHORE] Apply auxiliaryText on message body
kresnaputra Mar 15, 2021
d09aacc
change bodyText to uxiliaryText
kresnaputra Mar 16, 2021
226f75d
Merge branch 'develop' into chore.apply.auxiliarytext.on.message.body
diegolmello Mar 18, 2021
23090e5
Update tests
diegolmello Mar 18, 2021
53c6e79
Update bodyText color and rollback PR changes
gerzonc Apr 23, 2021
f9fdf94
Merge branch 'develop' into chore.apply.auxiliarytext.on.message.body
gerzonc Apr 23, 2021
b70657f
Update Storyshots.test.js.snap
gerzonc Apr 23, 2021
ba2e4ce
Merge branch 'develop' into chore.apply.auxiliarytext.on.message.body
gerzonc Jun 14, 2021
9c8ce5f
Minor tweak
gerzonc Jun 14, 2021
6a2d8fc
Merge branch 'develop' into chore.apply.auxiliarytext.on.message.body
diegolmello Jul 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions __tests__/__snapshots__/Storyshots.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11490,7 +11490,7 @@ exports[`Storyshots LoadMore black theme 1`] = `
},
undefined,
Object {
"color": "#e8ebed",
"color": "#cbced1",
},
]
}
Expand Down Expand Up @@ -11593,7 +11593,7 @@ exports[`Storyshots LoadMore black theme 1`] = `
},
undefined,
Object {
"color": "#e8ebed",
"color": "#cbced1",
},
]
}
Expand Down Expand Up @@ -11696,7 +11696,7 @@ exports[`Storyshots LoadMore black theme 1`] = `
},
undefined,
Object {
"color": "#e8ebed",
"color": "#cbced1",
},
]
}
Expand Down Expand Up @@ -11973,7 +11973,7 @@ exports[`Storyshots LoadMore black theme 1`] = `
},
undefined,
Object {
"color": "#e8ebed",
"color": "#cbced1",
},
]
}
Expand Down Expand Up @@ -12076,7 +12076,7 @@ exports[`Storyshots LoadMore black theme 1`] = `
},
undefined,
Object {
"color": "#e8ebed",
"color": "#cbced1",
},
]
}
Expand Down Expand Up @@ -12179,7 +12179,7 @@ exports[`Storyshots LoadMore black theme 1`] = `
},
undefined,
Object {
"color": "#e8ebed",
"color": "#cbced1",
},
]
}
Expand Down Expand Up @@ -12420,7 +12420,7 @@ exports[`Storyshots LoadMore black theme 1`] = `
},
undefined,
Object {
"color": "#e8ebed",
"color": "#cbced1",
},
]
}
Expand Down Expand Up @@ -12692,7 +12692,7 @@ exports[`Storyshots LoadMore dark theme 1`] = `
},
undefined,
Object {
"color": "#e8ebed",
"color": "#cbced1",
},
]
}
Expand Down Expand Up @@ -12795,7 +12795,7 @@ exports[`Storyshots LoadMore dark theme 1`] = `
},
undefined,
Object {
"color": "#e8ebed",
"color": "#cbced1",
},
]
}
Expand Down Expand Up @@ -12898,7 +12898,7 @@ exports[`Storyshots LoadMore dark theme 1`] = `
},
undefined,
Object {
"color": "#e8ebed",
"color": "#cbced1",
},
]
}
Expand Down Expand Up @@ -13175,7 +13175,7 @@ exports[`Storyshots LoadMore dark theme 1`] = `
},
undefined,
Object {
"color": "#e8ebed",
"color": "#cbced1",
},
]
}
Expand Down Expand Up @@ -13278,7 +13278,7 @@ exports[`Storyshots LoadMore dark theme 1`] = `
},
undefined,
Object {
"color": "#e8ebed",
"color": "#cbced1",
},
]
}
Expand Down Expand Up @@ -13381,7 +13381,7 @@ exports[`Storyshots LoadMore dark theme 1`] = `
},
undefined,
Object {
"color": "#e8ebed",
"color": "#cbced1",
},
]
}
Expand Down Expand Up @@ -13622,7 +13622,7 @@ exports[`Storyshots LoadMore dark theme 1`] = `
},
undefined,
Object {
"color": "#e8ebed",
"color": "#cbced1",
},
]
}
Expand Down Expand Up @@ -67631,7 +67631,7 @@ Array [
"textAlign": "left",
},
Object {
"color": "#e8ebed",
"color": "#cbced1",
},
Object {
"backgroundColor": "transparent",
Expand Down Expand Up @@ -67791,7 +67791,7 @@ Array [
"textAlign": "left",
},
Object {
"color": "#e8ebed",
"color": "#cbced1",
},
Object {
"backgroundColor": "transparent",
Expand Down Expand Up @@ -74309,7 +74309,7 @@ exports[`Storyshots Thread Messages.Item themes 1`] = `
"textAlign": "left",
},
Object {
"color": "#e8ebed",
"color": "#cbced1",
},
Object {
"flex": 1,
Expand Down Expand Up @@ -74661,7 +74661,7 @@ exports[`Storyshots Thread Messages.Item themes 1`] = `
"textAlign": "left",
},
Object {
"color": "#e8ebed",
"color": "#cbced1",
},
Object {
"flex": 1,
Expand Down
4 changes: 2 additions & 2 deletions app/constants/colors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export const themes = {
auxiliaryBackground: '#07101e',
bannerBackground: '#0e1f38',
titleText: '#f9f9f9',
bodyText: '#e8ebed',
bodyText: '#cbced1',
backdropColor: '#000000',
dangerColor: '#f5455c',
successColor: '#2de0a5',
Expand Down Expand Up @@ -121,7 +121,7 @@ export const themes = {
auxiliaryBackground: '#080808',
bannerBackground: '#1f2329',
titleText: '#f9f9f9',
bodyText: '#e8ebed',
bodyText: '#cbced1',
backdropColor: '#000000',
dangerColor: '#f5455c',
successColor: '#2de0a5',
Expand Down