Skip to content

[FIX] Show button attachment in message list#2980

Merged
diegolmello merged 13 commits intoRocketChat:developfrom
sumukhah:fix/button
Aug 27, 2021
Merged

[FIX] Show button attachment in message list#2980
diegolmello merged 13 commits intoRocketChat:developfrom
sumukhah:fix/button

Conversation

@sumukhah
Copy link
Contributor

@sumukhah sumukhah commented Mar 13, 2021

Proposed changes

The button attachment was not visible in the message list. Added a UI to show button attachments

Issue(s)

fixes: #2684

How to test or reproduce

Attach a button to a message. visit that message list.

Needs to send a message in chat.sendMessage with this type of message

{
    "message": {
        "rid": "GENERAL",
        "attachments": [
            {
                "text": "Test buttons",
                "actions": [
                    {
                        "type": "button",
                        "text": "Text button",
                        "msg": "Response message",
                        "msg_in_chat_window": true
                    }
                ]
            }
        ]
    }
}

Screenshots

Screenshot 2021-03-13 at 8 06 30 PM

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • [] Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Let me know if some styles need to be added or modified

@diegolmello
Copy link
Member

@sumukhah Really cool! Can you add stories? Also add stories with more buttons so we can see what happens when the layout breaks. Thanks!

Copy link
Contributor

@reinaldonetof reinaldonetof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CLAassistant
Copy link

CLAassistant commented Jul 29, 2021

CLA assistant check
All committers have signed the CLA.

# Conflicts:
#	storybook/stories/Message.js
@diegolmello diegolmello merged commit 9bfe0e9 into RocketChat:develop Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Button on message attachment not showing

5 participants