[FIX] Show button attachment in message list#2980
Merged
diegolmello merged 13 commits intoRocketChat:developfrom Aug 27, 2021
Merged
[FIX] Show button attachment in message list#2980diegolmello merged 13 commits intoRocketChat:developfrom
diegolmello merged 13 commits intoRocketChat:developfrom
Conversation
Member
|
@sumukhah Really cool! Can you add stories? Also add stories with more buttons so we can see what happens when the layout breaks. Thanks! |
sumukhah
commented
Mar 16, 2021
# Conflicts: # storybook/stories/Message.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The button attachment was not visible in the message list. Added a UI to show button attachments
Issue(s)
fixes: #2684
How to test or reproduce
Attach a button to a message. visit that message list.
Needs to send a message in
chat.sendMessagewith this type ofmessage{ "message": { "rid": "GENERAL", "attachments": [ { "text": "Test buttons", "actions": [ { "type": "button", "text": "Text button", "msg": "Response message", "msg_in_chat_window": true } ] } ] } }Screenshots
Types of changes
Checklist
Further comments
Let me know if some styles need to be added or modified