[FIX] Show thumbnails in message view#2975
Merged
diegolmello merged 8 commits intoRocketChat:developfrom Aug 27, 2021
Merged
Conversation
aee3079 to
0bc4261
Compare
Member
|
@sumukhah Thanks! Can you write stories for your change? |
Contributor
Author
|
Sure 👍 |
Contributor
Author
|
Added stories on thumbnails, @diegolmello should I update the snapshots? |
Member
|
@sumukhah Yes, run |
94a4bca to
8baa78c
Compare
8baa78c to
f6db9a6
Compare
71ccc4b to
3cab45f
Compare
Contributor
Author
|
@diegolmello |
Contributor
|
@sumukhah Can you resolve the conflicts? Thanks! |
Contributor
|
Hi, sumukhah, I resolved the conflicts. So, LGTM! Thanks for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Proposed changes
Added thumbnail views in messages.
Issue(s)
fixes: #2853
How to test or reproduce
Add a message thumbnail and test in the message list
Screenshots
{ "message": { "rid": "XMqEKWyZcvxZPsWLX", "attachments": [ { "title": "Joker", "text": "**Recommender:** + recommender + \n\n**Rating:** + rating + /10 based on + votecount + votes.\n**Released:** + releasedate + \n\n**Overview:** + overview", "thumb_url": "https://images-na.ssl-images-amazon.com/images/I/71jKxPAMFbL._AC_SL1500_.jpg", "color": "#FFD700", "title_link": "https://www.imdb.com/title/tt7286456/" } ] } }Types of changes
Checklist
Further comments
Some snapshot tests have failed in my local setup. I believe it is ok but I am not familiar with snapshot tests. So please tell me if any thing needs to be changed