-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[TESTS] Add E2E tests to draft message #2960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,9 +5,6 @@ const data = require('../../data'); | |
| const { navigateToLogin, login, mockMessage, tapBack, sleep, searchRoom, starMessage, pinMessage, dismissReviewNag, tryTapping } = require('../../helpers/app'); | ||
|
|
||
| async function navigateToRoom(roomName) { | ||
| await device.launchApp({ permissions: { notifications: 'YES' }, delete: true }); | ||
| await navigateToLogin(); | ||
| await login(data.users.regular.username, data.users.regular.password); | ||
| await searchRoom(`${ roomName }`); | ||
| await waitFor(element(by.id(`rooms-list-view-item-${ roomName }`))).toExist().withTimeout(60000); | ||
| await element(by.id(`rooms-list-view-item-${ roomName }`)).tap(); | ||
|
|
@@ -18,6 +15,9 @@ describe('Room screen', () => { | |
| const mainRoom = data.groups.private.name; | ||
|
|
||
| before(async() => { | ||
| await device.launchApp({ permissions: { notifications: 'YES' }, delete: true }); | ||
| await navigateToLogin(); | ||
| await login(data.users.regular.username, data.users.regular.password); | ||
| await navigateToRoom(mainRoom); | ||
| }); | ||
|
|
||
|
|
@@ -126,6 +126,20 @@ describe('Room screen', () => { | |
| await expect(element(by.id('messagebox-input'))).toHaveText('#general '); | ||
| await element(by.id('messagebox-input')).clearText(); | ||
| }); | ||
|
|
||
| it('should draft message', async () => { | ||
| await element(by.id('messagebox-input')).atIndex(0).tap(); | ||
| await element(by.id('messagebox-input')).atIndex(0).typeText(`${ data.random }draft`); | ||
| await tapBack(); | ||
|
|
||
| await navigateToRoom(mainRoom); | ||
| await expect(element(by.id('messagebox-input'))).toHaveText(`${ data.random }draft`); | ||
| await element(by.id('messagebox-input')).clearText(); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You should test if draft was removed after messagebox is cleared. |
||
| await tapBack(); | ||
|
|
||
| await navigateToRoom(mainRoom); | ||
| await expect(element(by.id('messagebox-input'))).toHaveText(''); | ||
| }); | ||
| }); | ||
|
|
||
| describe('Message', async() => { | ||
|
|
@@ -352,6 +366,27 @@ describe('Room screen', () => { | |
| await expect(element(by.id('thread-messages-view'))).toExist(); | ||
| await tapBack(); | ||
| }); | ||
|
|
||
| it('should draft thread message', async () => { | ||
| await element(by.id(`message-thread-button-${ thread }`)).tap(); | ||
| await waitFor(element(by.id('room-view'))).toBeVisible().withTimeout(5000); | ||
| await waitFor(element(by.id(`room-view-title-${ thread }`))).toExist().withTimeout(5000); | ||
| await element(by.id('messagebox-input')).atIndex(0).tap(); | ||
| await element(by.id('messagebox-input')).atIndex(0).typeText(`${ thread }draft`); | ||
| await tapBack(); | ||
|
|
||
| await element(by.id(`message-thread-button-${ thread }`)).tap(); | ||
| await waitFor(element(by.id('room-view'))).toBeVisible().withTimeout(5000); | ||
| await waitFor(element(by.id(`room-view-title-${ thread }`))).toExist().withTimeout(5000); | ||
| await expect(element(by.id('messagebox-input')).atIndex(0)).toHaveText(`${ thread }draft`); | ||
| await element(by.id('messagebox-input')).atIndex(0).clearText(); | ||
| await tapBack(); | ||
|
|
||
| await element(by.id(`message-thread-button-${ thread }`)).tap(); | ||
| await waitFor(element(by.id('room-view'))).toBeVisible().withTimeout(5000); | ||
| await waitFor(element(by.id(`room-view-title-${ thread }`))).toExist().withTimeout(5000); | ||
| await expect(element(by.id('messagebox-input')).atIndex(0)).toHaveText(''); | ||
| }); | ||
| }); | ||
|
|
||
| // after(async() => { | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should test if the room has rendered before testing messagebox content.