Skip to content

[CHORE] Force normalized params for 2FA#2683

Merged
diegolmello merged 2 commits intodevelopfrom
chore.totp
Dec 1, 2020
Merged

[CHORE] Force normalized params for 2FA#2683
diegolmello merged 2 commits intodevelopfrom
chore.totp

Conversation

@djorkaeffalexandre
Copy link
Contributor

Proposed changes

We need to send user and password for any login calls with 2FA starting RC 3.9.0.

Issue(s)

How to test or reproduce

  • Try login into a server with version < 3.9.0 with TOTP enabled
  • Try login into a server with version < 3.9.0 with LDAP + TOTP enabled
  • Try login into a server with version < 3.9.0 with CROWD + TOTP enabled
  • Try login into a server with version >= 3.9.0 with TOTP enabled
  • Try login into a server with version >= 3.9.0 with LDAP + TOTP enabled
  • Try login into a server with version >= 3.9.0 with CROWD + TOTP enabled

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

I don't have LDAP or CROWD enabled servers, we need to configure some servers to do these tests.

@djorkaeffalexandre djorkaeffalexandre changed the title [WIP] Force normalized params for 2FA [CHORE] Force normalized params for 2FA Nov 30, 2020
@diegolmello diegolmello merged commit 3bc8161 into develop Dec 1, 2020
@diegolmello diegolmello deleted the chore.totp branch December 1, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants