[FIX] Initial users' status is not fetched#2664
Merged
diegolmello merged 1 commit intoRocketChat:developfrom Dec 1, 2020
Merged
[FIX] Initial users' status is not fetched#2664diegolmello merged 1 commit intoRocketChat:developfrom
diegolmello merged 1 commit intoRocketChat:developfrom
Conversation
djorkaeffalexandre
approved these changes
Nov 20, 2020
Contributor
djorkaeffalexandre
left a comment
There was a problem hiding this comment.
LGTM, nice catch!
Reproducible steps:
- Just scroll down the rooms list
- It's not requesting user presence again
Member
|
@zaphod534 Can you update your branch? |
844447a to
5a09f6e
Compare
Contributor
Author
|
I have updated the PR, now you should be able to merge it. We can add you as contributor to our repo in order to be able to check the option next time. |
Member
Awesome. It makes sense now. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue(s)
#2663
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments