[NEW] Support client certificates for SSL (two-way authentication) (Android)#2624
Merged
diegolmello merged 18 commits intodevelopfrom Nov 30, 2020
Merged
[NEW] Support client certificates for SSL (two-way authentication) (Android)#2624diegolmello merged 18 commits intodevelopfrom
diegolmello merged 18 commits intodevelopfrom
Conversation
diegolmello
approved these changes
Nov 30, 2020
|
What about iOS app and 2FA with SSL support? |
Member
|
@C1ean iOS has this feature since last year.
Can you give us more details on a new issue? |
Contributor
|
IMHO this PR breaks SSO auth, where used IDP offers also optional mutual TLS authentication. I don't have any cert on my Android device and white SSO login page is generated (there is IDP login form in the previous app version). Do you have any recommendation how to investigate this from the user point of view? |
Member
|
@jangaraj Can you open a new issue with detailed information? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Implements TLS Client/mutual authentication with Certificate Pinning to Android devices.
Issue(s)
Close #1711
How to test or reproduce
Pin a certificate and connect to a server protected by a client ssl certificate.
This list consider what is implemented on iOS
Screenshots
Types of changes
Checklist
Further comments
Let's move changes of
react-nativeandreact-native-fast-imageto our own forks.