Skip to content

[i18n] Added Arabic translation#1941

Closed
AlkindiX wants to merge 12 commits intoRocketChat:developfrom
AlkindiX:develop
Closed

[i18n] Added Arabic translation#1941
AlkindiX wants to merge 12 commits intoRocketChat:developfrom
AlkindiX:develop

Conversation

@AlkindiX
Copy link

@RocketChat/ReactNative
This new pull request add Arabic translation to Rocket chat Reactive project.

@CLAassistant
Copy link

CLAassistant commented Mar 25, 2020

CLA assistant check
All committers have signed the CLA.

@AlkindiX
Copy link
Author

Please Review

@diegolmello
Copy link
Member

Thanks for opening, @AlkindiX.
We'll take a look soon.

Copy link
Contributor

@abalhamoud abalhamoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor fixes and suggestions on the translation. :)

@diegolmello
Copy link
Member

Hey, @abalhamoud.
This PR is quite old, so there're missing keys.
Do you mind opening a new one?
I'll make sure @AlkindiX is marked as co-author.
Thank you, guys.

AlkindiX and others added 10 commits October 5, 2020 18:24
Co-authored-by: Abdullah Alhamoud <10301923+abalhamoud@users.noreply.github.com>
Co-authored-by: Abdullah Alhamoud <10301923+abalhamoud@users.noreply.github.com>
Co-authored-by: Abdullah Alhamoud <10301923+abalhamoud@users.noreply.github.com>
Co-authored-by: Abdullah Alhamoud <10301923+abalhamoud@users.noreply.github.com>
Co-authored-by: Abdullah Alhamoud <10301923+abalhamoud@users.noreply.github.com>
Co-authored-by: Abdullah Alhamoud <10301923+abalhamoud@users.noreply.github.com>
Co-authored-by: Abdullah Alhamoud <10301923+abalhamoud@users.noreply.github.com>
Co-authored-by: Abdullah Alhamoud <10301923+abalhamoud@users.noreply.github.com>
Co-authored-by: Abdullah Alhamoud <10301923+abalhamoud@users.noreply.github.com>
Co-authored-by: Abdullah Alhamoud <10301923+abalhamoud@users.noreply.github.com>
@AlkindiX
Copy link
Author

AlkindiX commented Oct 5, 2020

I forgot about this PR. It was a while ago. @abalhamoud thank you for your contribution. Too many commits to merge. @diegolmello you can close this commit and @abalhamoud to open a new one instead of this with all the corrections and new keys.

Thanks

Copy link
Author

@AlkindiX AlkindiX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just reviewed most the changes

@abalhamoud
Copy link
Contributor

Sure @diegolmello I will open a new PR with the latest keys. Thanks to @AlkindiX for the contribution.

@AlkindiX
Copy link
Author

AlkindiX commented Oct 7, 2020

Closing this pull request

@AlkindiX AlkindiX closed this Oct 7, 2020
@abalhamoud
Copy link
Contributor

@diegolmello I have opened a new PR #2537 for the translation. Please check.

@diegolmello
Copy link
Member

I'm going to review it soon.
Thanks, guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants