[FIX]Makes consective soft line breaks compatible#1714
Closed
aKn1ghtOut wants to merge 2 commits intoRocketChat:developfrom
aKn1ghtOut:fix1513
Closed
[FIX]Makes consective soft line breaks compatible#1714aKn1ghtOut wants to merge 2 commits intoRocketChat:developfrom aKn1ghtOut:fix1513
aKn1ghtOut wants to merge 2 commits intoRocketChat:developfrom
aKn1ghtOut:fix1513
Conversation
Contributor
|
Closed by #1783 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/ReactNative
Closes #1513
Write a message like this
Browser Render:
Current app render:
FIXED app render:
The commonmark library has a policy to format new line characters to be rendered. Added that in the formatText function where link tags were already being processed, instead of how I did this in the render function before(was wrong to put it there).