Skip to content

[FIX] Change force logout rule #1640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegolmello merged 2 commits into from
Jan 30, 2020
Merged

[FIX] Change force logout rule #1640

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ced7896
[FIX] Change force logout rule
diegolmello Jan 30, 2020
00f7122
Merge branch 'develop' into fix.check-login-error-msg
diegolmello Jan 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/sagas/login.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,11 @@ const handleLoginRequest = function* handleLoginRequest({ credentials, logoutOnE
result = yield call(loginWithPasswordCall, credentials);
}
return yield put(loginSuccess(result));
} catch (error) {
if (logoutOnError) {
} catch (e) {
if (logoutOnError && (e.data && e.data.message && /you've been logged out by the server/i.test(e.data.message))) {
Copy link
Member

@ggazzo ggazzo Jan 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

yield put(logout());
} else {
yield put(loginFailure(error));
yield put(loginFailure(e));
}
}
};
Expand Down