[FIX] Email verification message and navigation to login portal#1567
Closed
m1-key wants to merge 3 commits intoRocketChat:developfrom
Closed
[FIX] Email verification message and navigation to login portal#1567m1-key wants to merge 3 commits intoRocketChat:developfrom
m1-key wants to merge 3 commits intoRocketChat:developfrom
Conversation
m1-key
changed the title
diegolmello
requested changes
Feb 3, 2020
| Username: '用户名', | ||
| Username_or_email: '用户名或邮箱', | ||
| Validating: '正在验证', | ||
| Verify_your_email: '验证您的电子邮件', |
Member
There was a problem hiding this comment.
If you don't know the language, you shouldn't use Google Translate.
| name, email, pass: password, username, ...customFields | ||
| }); | ||
| await loginRequest({ user: email, password }); | ||
| const { navigation } = this.props; |
Member
There was a problem hiding this comment.
There's a setting on the server enforcing email verification.
You should do this only if that setting is enabled.
Member
|
Will be fixed by #1725 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/ReactNative
Closes #1548
In this I have created an Alert Screen , which pop up when a user press the register button ( when he/she is registering through
Create an accountoption, not by any pre-described methods likeContinue via Google, GitHub etc. ) . On that alert screen Congrats will be written for registering on Rocket Chat and then there will be a message Verify your email and a close button. Now user will have information that they have to verify their email which was not mentioned earlier. And on pressing the close button, user will be redirected to LoginView i.e Login Portal, where after successfully verifying the mail , user can login.I have removed the
login requestprop, so user will only be able to login once the email is verified.Login via Google , GitHub etc issue is resolved the pull request I made in #1544 , so if both the pull requests are merged then whole register issue will be resolved. i.e
When we register via google, github then on pressing the register button , we will be redirected to Room List (#1544 ) and when we choose
Create an Accountand press register button then we will be redirected to login portal and message will be displayed which will say to verify the email.Here is view of that.
One thing more is that I have provided the message 'Congrats' and 'Verify your email' in all the languages supported by the app.