Skip to content

[IMPROVEMENT] Honor Accounts_ShowFormLogin setting#1308

Closed
Caiocbeleza wants to merge 5 commits intoRocketChat:developfrom
djorkaeffalexandre:Accounts_ShowFormLogin
Closed

[IMPROVEMENT] Honor Accounts_ShowFormLogin setting#1308
Caiocbeleza wants to merge 5 commits intoRocketChat:developfrom
djorkaeffalexandre:Accounts_ShowFormLogin

Conversation

@Caiocbeleza
Copy link

@RocketChat/ReactNative

Closes #1123

@djorkaeffalexandre djorkaeffalexandre changed the title Resolving issue #1123 [IMPROVEMENT] Honor Accounts_ShowFormLogin setting Oct 15, 2019
Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should create your own server and test if it behaves correctly.
We have two similar login views: LoginView and LoginSignupView.
If there're no login services, the user is redirected to LoginView.
Also, it seems Accounts_ShowFormLogin hides register as well.

@ankar84
Copy link
Contributor

ankar84 commented Nov 13, 2019

We will use only KeyCloak as only one identify provider for our Rocket.Chat, and we disabled all other things, such as registration form, logon form, password reminder and other.
In browser or desktop application logon page shows only on KeyCloak button - it's good.
But RN mobile app shows Login with e-mail button and Create an account link - it's bad.
So we totally need this feature!
Can you finish it so we can get it merged?

@djorkaeffalexandre
Copy link
Contributor

Hey guys.
It'll be solved by #1727.
Closing it now.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[IMPROVEMENT] Honor Accounts_ShowFormLogin setting

4 participants