[NEW] Delete server#1302
[NEW] Delete server#1302CalebeRios wants to merge 5 commits intoRocketChat:developfrom djorkaeffalexandre:feature.remove_server
Conversation
|
I think is better if you remove all data about this server when delete it on ServerDropdown.. like the database, |
diegolmello
left a comment
There was a problem hiding this comment.
@CalebeRios I've fixed unnecessary changes, warnings and an if condition on this PR.
Can you fix the delete method?
On RocketChat.logout, we have this delete steps implemented already: https://github.com/RocketChat/Rocket.Chat.ReactNative/blob/develop/app/lib/rocketchat.js#L342
You could move part of the logic to a new method called removeServer and call it on logout and on ServerDropdown.
|
Thanks for changes @diegolmello. I will see the changes you made and finish that issue. My problem is to delete the database, because in logout we delete the active database, and I need get the database of another server. Can you give me a light? |
|
@CalebeRios Ok. From there, you can receive a database obj and run an action to reset it. |
Co-authored-by: Bruno Dantas <oliveiradantas96@gmail.com> Fix function to delete server Co-authored-by: Bruno Dantas <oliveiradantas96@gmail.com> Translate messages of alert for brazilian portugues and english Co-authored-by: Bruno Dantas <oliveiradantas96@gmail.com>
… database of server Separates responsibilities of functions
|
@djorkaeffalexandre @diegolmello I made the changes you request. Sorry for the delay. |
|
It'll be closed by #1975 . |
Fix function to delete server
Translate messages of alert for brazilian portugues and english
Co-authored-by: Bruno Dantas oliveiradantas96@gmail.com
@RocketChat/ReactNative
Closes #1087