Skip to content

[FIX] Update last open on message stream received #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegolmello merged 2 commits into from
Sep 26, 2019
Merged

[FIX] Update last open on message stream received #1240

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e813efe
[FIX] Update last open on message stream received
diegolmello Sep 26, 2019
464fafc
Merge branch 'develop' into fix.last-open
diegolmello Sep 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/lib/methods/subscriptions/room.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ export default function subscribeRoom({ rid }) {

const handleMessageReceived = protectedFunction((ddpMessage) => {
const message = buildMessage(EJSON.fromJSONValue(ddpMessage.fields.args[0]));
const lastOpen = new Date();
if (rid !== message.rid) {
return;
}
Expand Down Expand Up @@ -163,7 +164,7 @@ export default function subscribeRoom({ rid }) {

try {
await subCollection.find(rid);
this.readMessages(rid);
this.readMessages(rid, lastOpen);
} catch (e) {
console.log('Subscription not found. We probably subscribed to a not joined channel. No need to mark as read.');
}
Expand Down