Skip to content

[IMPROVEMENT] Use autoFocus rather than timeout + focus#1071

Merged
diegolmello merged 5 commits intoRocketChat:developfrom
tanujsinghkushwah:develop
Aug 7, 2019
Merged

[IMPROVEMENT] Use autoFocus rather than timeout + focus#1071
diegolmello merged 5 commits intoRocketChat:developfrom
tanujsinghkushwah:develop

Conversation

@tanujsinghkushwah
Copy link
Contributor

@RocketChat/ReactNative

Closes #1067

@diegolmello
Copy link
Member

Thanks for your PR, @tj4752!
It looks ok, but I'm going to review it properly only next week.
We're finishing last steps of 1.17.0 and we're going to release it by monday/tuesday.
Cheers.

Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegolmello diegolmello merged commit 7b2185d into RocketChat:develop Aug 7, 2019
@diegolmello
Copy link
Member

@tj4752 Merged. Thank you! 👊

djorkaeffalexandre pushed a commit that referenced this pull request Aug 9, 2019
* autofocus replaced timout+focus

* removed inputRef

* Unnecessary focus on NewServerView when passing server as props

* Removed unnecessary code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[IMPROVEMENT] Use autoFocus rather than timeout + focus

4 participants