Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump a bunch of development dependencies #659

Merged
merged 7 commits into from
Aug 31, 2023

Conversation

tassoevan
Copy link
Contributor

What? ⛵

  • Upgraded uuid dependency (and @types/uuid) to match the main repository;
  • Upgraded typescript and typedoc;
  • Replaced tslint with eslint.

Why? 🤔

It was reported that some ocasional collisions between types of uuid exist, therefore is not far-fetched to assume there is a risk of colliding the library itself.
Also, using the standard ESLint configuration would keep the consistency we adhere in other codebases in the organization.

Links 🌎

PS 👀

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@d-gubert d-gubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit, thank you so much!

@d-gubert d-gubert merged commit 317a0de into RocketChat:alpha Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants