Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Fixed Masked SettingType #582

Open
wants to merge 4 commits into
base: alpha
Choose a base branch
from

Conversation

ashnove
Copy link

@ashnove ashnove commented Feb 4, 2023

This closes #238

The fix/hack I've added is to append a PASSWORD attribute to the SettingType enum and used it in the provideSetting configuration.

@CLAassistant
Copy link

CLAassistant commented Feb 4, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ ashnove
✅ d-gubert
❌ casalsgh
You have signed the CLA already but the status is still pending? Let us recheck it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@graywolf336
Copy link
Contributor

Is this a duplicate of #577?

@ashnove
Copy link
Author

ashnove commented Feb 7, 2023

Is this a duplicate of #577?

Seems like it

@pierre-lehnen-rc
Copy link
Contributor

Just the first part - My PR only adds password to the list, but doesn't change any setting to use it.

@casalsgh casalsgh requested review from d-gubert and a team February 8, 2023 16:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add masked SettingType
6 participants